Re: [PATCH v16 5/7] drm/vkms: Create KUnit tests for YUV conversions

Louis Chauvet
2025-01-27T10:48:34Z

On 26/01/25 - 18:06, Maxime Ripard wrote:
> On Tue, Jan 21, 2025 at 11:48:06AM +0100, Louis Chauvet wrote:
> > +static struct yuv_u8_to_argb_u16_case yuv_u8_to_argb_u16_cases[] = {
> > + /*
> > + * colour.RGB_to_YCbCr(<rgb color in 16 bit form>,
> > + * K=colour.WEIGHTS_YCBCR["ITU-R BT.601"],
> > + * in_bits = 16,
> > + * in_legal = False,
> > + * in_int = True,
> > + * out_bits = 8,
> > + * out_legal = False,
> > + * out_int = True)
> > + *
> > + * Test cases for conversion between YUV BT601 full range and RGB
> > + * using the ITU-R BT.601 weights.
> > + */
>
> What are the input and output formats?
>
> Ditto for all the other tests.

There is no really "input" and "output" format, they are reference values
for conversion, you should be able to use it in both direction. They are
generated by RGB_to_YCbCr (RGB input, YUV output) just because it was
easier to create the colors from RGB values.

If you think we should specify what is was used as input and output to
generate those values, I can modify the comment to:

Tests cases for color conversion generated by converting RGB
values to YUV BT601 full range using the ITU-R BT.601 weights.

Beside that modification, did you notice anything else on the series that
require more work before adding your Ack-by/Reviewed-by on the other
patches?

Thanks,
Louis Chauvet

> Maxime