Re: [PATCH v3 2/6] exit: hoist get_pid() in release_task() outside of tasklist_lock

Mateusz Guzik
2025-02-03T19:36:01Z

On Mon, Feb 3, 2025 at 8:27 PM Liam R. Howlett <Liam.Howlett@oracle.com> wrote:
>
> * Mateusz Guzik <mjguzik@gmail.com> [250201 11:31]:
> > Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
>
> Change log is a bit sparse? I get that the subject spells out what is
> done, but anything to say here at all? Reduces lock contention by
> reducing lock time or something? Maybe even some numbers you have in
> the cover letter?
>

I did not measure this bit *specifically*.

As one can expect get_pid issues an atomic and that's slow. And since
it can happen *prior* to taking the global lock it seems like an
obvious little nit to sort out.

I would argue the change is self-explanatory given the cover-letter.

--
Mateusz Guzik <mjguzik gmail.com>