Re: [PATCH v3 1/6] exit: perform add_device_randomness() without tasklist_lock

Mateusz Guzik
2025-02-03T17:55:54Z

On Mon, Feb 3, 2025 at 6:51 PM Oleg Nesterov <oleg@redhat.com> wrote:
>
> On 02/01, Mateusz Guzik wrote:
> >
> > + add_device_randomness((const void*) &p->se.sum_exec_runtime,
> > + sizeof(unsigned long long));
>
> I won't insist, but do we really need to keep this ugly "(const void*)"
> typecast? and perhaps sizeof(p->se.sum_exec_runtime) will look a bit
> better?
>

Thanks for the review, I'm going to wait for Eric to chime in before
doing anything here.

As for the thing at hand, I tried avoid messing with it in order to
reduce discussion. :->

However, we seem to be in agreement this should be augmented, so I'm
going to do it in v4.

--
Mateusz Guzik <mjguzik gmail.com>