Re: [PATCH] WIP: drivers/base: Add virtual_device_create()

kernel test robot
2025-01-31T03:35:08Z

Hi Lyude,

kernel test robot noticed the following build warnings:

url: https://github.com/intel-lab-lkp/linux/commits/UPDATE-20250131-052936/Lyude-Paul/rust-kernel-Add-platform-Device-from_raw/20250123-075718
base: the 2th patch of https://lore.kernel.org/r/20250122235340.2145383-3-lyude%40redhat.com
patch link: https://lore.kernel.org/r/20250130212843.659437-1-lyude%40redhat.com
patch subject: [PATCH] WIP: drivers/base: Add virtual_device_create()
config: arc-randconfig-001-20250131 (https://download.01.org/0day-ci/archive/20250131/202501311112.BDhClMYs-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250131/202501311112.BDhClMYs-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501311112.BDhClMYs-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/base/core.c:4409: warning: Excess function parameter 'class' description in 'virtual_device_create'

vim +4409 drivers/base/core.c

4392
4393 /**
4394 * virtual_device_create - creates a virtual device and registers it with sysfs
4395 * @class: optional pointer to a struct class this device should be registered to
4396 * @drvdata: the data to be added to the device for the callbacks
4397 * @fmt: string for the device's name
4398 *
4399 * This function can be used to create standalone virtual devices, optionally
4400 * registered to a specific class. Drivers which create virtual devices can use
4401 * this. The device will live in /sys/devices/virtual.
4402 *
4403 * A pointer to the struct device will be returned from the call. Any further
4404 * sysfs files that might be required can be created using this pointer.
4405 *
4406 * Returns &struct device pointer on success or ERR_PTR() on error.
4407 */
4408 struct device *virtual_device_create(void *drvdata, const char *fmt, ...)
> 4409 {
4410 va_list vargs;
4411 struct device *dev;
4412
4413 va_start(vargs, fmt);
4414 dev = device_create_groups_vargs(NULL, NULL, 0, drvdata, NULL,
4415 fmt, vargs);
4416 va_end(vargs);
4417 return dev;
4418 }
4419 EXPORT_SYMBOL_GPL(virtual_device_create);
4420

--
0-DAY CI Kernel Test Service