public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Edward Adam Davis <eadavis@qq.com>
Cc: syzbot+8928e473a91452caca2f@syzkaller.appspotmail.com,
	dakr@kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org, rafael@kernel.org,
	syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] debugfs: add fsd's methods initialization
Date: Mon, 3 Feb 2025 09:14:51 +0100	[thread overview]
Message-ID: <2025020345-breath-comma-4097@gregkh> (raw)
In-Reply-To: <tencent_8D66623CFF36BA96EE36FE4B7474B1778509@qq.com>

On Mon, Feb 03, 2025 at 11:27:56AM +0800, Edward Adam Davis wrote:
> syzbot reported a uninit-value in full_proxy_unlocked_ioctl. [1]
> 
> The newly created fsd does not initialize methods, and increases the
> initialization of methods for fsd.
> 
> [1]
> BUG: KMSAN: uninit-value in full_proxy_unlocked_ioctl+0xed/0x3a0 fs/debugfs/file.c:399
>  full_proxy_unlocked_ioctl+0xed/0x3a0 fs/debugfs/file.c:399
>  vfs_ioctl fs/ioctl.c:51 [inline]
>  __do_sys_ioctl fs/ioctl.c:906 [inline]
>  __se_sys_ioctl+0x246/0x440 fs/ioctl.c:892
>  __x64_sys_ioctl+0x96/0xe0 fs/ioctl.c:892
>  x64_sys_call+0x19f0/0x3c30 arch/x86/include/generated/asm/syscalls_64.h:17
>  do_syscall_x64 arch/x86/entry/common.c:52 [inline]
>  do_syscall_64+0xcd/0x1e0 arch/x86/entry/common.c:83
>  entry_SYSCALL_64_after_hwframe+0x77/0x7f
> 
> Fixes: 41a0ecc0997c ("debugfs: get rid of dynamically allocation proxy_ops")
> Reported-by: syzbot+8928e473a91452caca2f@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=8928e473a91452caca2f
> Tested-by: syzbot+8928e473a91452caca2f@syzkaller.appspotmail.com
> Signed-off-by: Edward Adam Davis <eadavis@qq.com>
> ---
>  fs/debugfs/file.c | 1 +
>  1 file changed, 1 insertion(+)

Is this still an issue on 6.14-rc1, specifically after commit
57b314752ec0 ("debugfs: Fix the missing initializations in
__debugfs_file_get()")?

thanks,

greg k-h

  reply	other threads:[~2025-02-03  8:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-02 13:28 [syzbot] [fs?] KMSAN: uninit-value in full_proxy_unlocked_ioctl syzbot
2025-02-03  1:54 ` Edward Adam Davis
2025-02-03  2:57   ` syzbot
2025-02-03  3:27 ` [PATCH] debugfs: add fsd's methods initialization Edward Adam Davis
2025-02-03  8:14   ` Greg KH [this message]
2025-02-03 11:05     ` Edward Adam Davis
2025-02-03 11:27       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025020345-breath-comma-4097@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dakr@kernel.org \
    --cc=eadavis@qq.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=syzbot+8928e473a91452caca2f@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox