From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC3332036F0; Tue, 4 Feb 2025 01:19:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738631947; cv=none; b=bcM5YVsuLZ5OGuD0sv/D7m7xxOzirMRS4W+FgOqmeP2MhHH3YbMu5sbjkkZkbrpy1yb37+Q5aRK4h3wEl8+Rq2bI0V8n++tUhim8Oo/KQJWldRp5wu3gGEgN/3TDHDrwZaYImuwY1rEiAswWYJu+fmX5/4dX34YXyRgJ/kWRs2o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738631947; c=relaxed/simple; bh=U5xUI/dJojXi8jaM2KImFDgZC+wj5t9cCLBkF+tjfyk=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=u7CaKq9Q01ngzX5y1ThaHnD42DUda2opA0ODrUW3W3jonE/Z4jlVVjJp7Tfp5ynUyn1Q2hTjHkXWv/PshL5LXORYW7E2okoBTAKvBCWWNgUshU9d/QzWNO9AAe5lO2QIFUqsogdFfuM55PAFmmT4Y+gYTjxrKC7DFZjY8XNf0xk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rFluqJBd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rFluqJBd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D417C4CEE0; Tue, 4 Feb 2025 01:19:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738631946; bh=U5xUI/dJojXi8jaM2KImFDgZC+wj5t9cCLBkF+tjfyk=; h=From:To:Cc:Subject:Date:From; b=rFluqJBd86cGE5XAcYbYYEe068ZN11EGw+5BNsbnYFwRLsNgbcWcGRlPKGhvseZwr R2V361+BW6B2smRfm8uOkD8Qen6j2hYuf/gYtagQ4swYt+MxPCKpAJIKLYEzJkctly A1PPZZVvg83a9Za3cgTbjdL6hHNVGZ1vvF4DJBJDW+U1snZYljNcCmxIsMthxm828q 0PBoRonkz5DkrseyHawKKMudk5vAbjDTuuOf0hjkgbUI7WsAmtlU0IaIlGJ5joNAGQ In1CYkRBK+5cmrSXs0hR16x2OzqoMc1HBFIzgeialCEzgJjWvvbf9dhgaIBBO4F56N rM4x+AumzbBng== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Mike Marshall , syzbot+fc519d7875f2d9186c1f@syzkaller.appspotmail.com, Sasha Levin , devel@lists.orangefs.org Subject: [PATCH AUTOSEL 5.4 1/2] orangefs: fix a oob in orangefs_debug_write Date: Mon, 3 Feb 2025 20:19:01 -0500 Message-Id: <20250204011902.2207294-1-sashal@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.290 Content-Transfer-Encoding: 8bit From: Mike Marshall [ Upstream commit f7c848431632598ff9bce57a659db6af60d75b39 ] I got a syzbot report: slab-out-of-bounds Read in orangefs_debug_write... several people suggested fixes, I tested Al Viro's suggestion and made this patch. Signed-off-by: Mike Marshall Reported-by: syzbot+fc519d7875f2d9186c1f@syzkaller.appspotmail.com Signed-off-by: Sasha Levin --- fs/orangefs/orangefs-debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/orangefs/orangefs-debugfs.c b/fs/orangefs/orangefs-debugfs.c index 1b508f5433846..fa41db0884880 100644 --- a/fs/orangefs/orangefs-debugfs.c +++ b/fs/orangefs/orangefs-debugfs.c @@ -393,9 +393,9 @@ static ssize_t orangefs_debug_write(struct file *file, * Thwart users who try to jamb a ridiculous number * of bytes into the debug file... */ - if (count > ORANGEFS_MAX_DEBUG_STRING_LEN + 1) { + if (count > ORANGEFS_MAX_DEBUG_STRING_LEN) { silly = count; - count = ORANGEFS_MAX_DEBUG_STRING_LEN + 1; + count = ORANGEFS_MAX_DEBUG_STRING_LEN; } buf = kzalloc(ORANGEFS_MAX_DEBUG_STRING_LEN, GFP_KERNEL); -- 2.39.5