public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Andre Werner <andre.werner@systec-electronic.com>
Cc: jirislaby@kernel.org, hvilleneuve@dimonoff.com, andy@kernel.org,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	lech.perczak@camlingroup.com, Maarten.Brock@sttls.nl
Subject: Re: [PATCH v4] serial: sc16is7xx: Fix IRQ number check behavior
Date: Tue, 4 Feb 2025 14:42:36 +0100	[thread overview]
Message-ID: <2025020422-reflected-huff-3334@gregkh> (raw)
In-Reply-To: <20250121071819.1346672-1-andre.werner@systec-electronic.com>

On Tue, Jan 21, 2025 at 08:18:19AM +0100, Andre Werner wrote:
> The logical meaning of the previous version is wrong due to a typo.
> 
> If the IRQ equals 0, no interrupt pin is available and polling mode
> shall be used.
> 
> Additionally, this fix adds a check for IRQ < 0 to increase robustness,
> because documentation still says that negative IRQ values cannot be
> absolutely ruled-out.
> 
> Fixes: 104c1b9dde9d859dd01bd2d ("serial: sc16is7xx: Add polling mode if no IRQ pin is available")

Nit, this should be:
	Fixes: 104c1b9dde9d ("serial: sc16is7xx: Add polling mode if no IRQ pin is available")

I'll go fix up the fixes line...

thanks,

greg k-h

      parent reply	other threads:[~2025-02-04 13:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21  7:18 [PATCH v4] serial: sc16is7xx: Fix IRQ number check behavior Andre Werner
2025-01-21  8:42 ` Jiri Slaby
2025-01-21 10:23 ` Maarten Brock
2025-01-21 13:33 ` Andy Shevchenko
2025-01-21 14:24   ` Hugo Villeneuve
2025-02-04 13:42 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025020422-reflected-huff-3334@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Maarten.Brock@sttls.nl \
    --cc=andre.werner@systec-electronic.com \
    --cc=andy@kernel.org \
    --cc=hvilleneuve@dimonoff.com \
    --cc=jirislaby@kernel.org \
    --cc=lech.perczak@camlingroup.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox