From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 666F6623; Wed, 5 Feb 2025 12:51:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738759884; cv=none; b=q6QXdNJ0IfdWtHEwXEQYxVFYJaxhlZB6IWDFaPbCdcDgHhiTQ4+AaTy0KxZZXQlzAAiQ0/5oEtZJThT8Sk8FHuypJvg4r7s4F9ciE9cGYk7DLWXkHFL4CcOPyIRpCJG7uXOReJj0A+yO5NMdD8jZm0EfGriFLu1atWhFNhil7+4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738759884; c=relaxed/simple; bh=LbS2QAr94GKb9Q8ZQia8Tn+AusZedBX3FaUndVsUInU=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EZrqIhR8VteNbtJzyrtRq3YOkPt1IvSPyTeOyO1ULlYB1lsGkYMgy8IIAfOrnq8dUHat2wBrQrN2lZDbQ2GPPaMbllgZI132DePOQeXpFdmap39Z0tFUNrGJ0yCXMiGm2UPir5DpNHL7Own3Tw8TrnUK21rz+lWVgNWe3t25tK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=aIv+EmAe; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="aIv+EmAe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1738759875; bh=LbS2QAr94GKb9Q8ZQia8Tn+AusZedBX3FaUndVsUInU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=aIv+EmAe5lVZN2aKpqFDOZkiypQidX6gU8Jqd6Lf3rcUySVl0uOYg09i8+37v1tQy 7xhJcDTXcc4fANIkpIffskBCi3Y1vO4NCUHDca8Sf7M5iXhu00LjrivsZW/CtW4jsH f9a4a00al2b2ruhttf7ts3opBWdCECUie0MfuBIyAETBsFkb2Y2vozziWG7/pBiieU KW+UokmJ3ko+5Xy945SOoDOnuXdm5xNNwZTTesnGcZuFACjeE/tTD+Fnd6Rn6HjYsV RXtab/ZrvAYVDGEymP1unwLdRLXJEtGY6cy7O/RFZBFQETqlJExlbv5n9RpJ1+YiAM LfH1rUmhUl/jA== Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 9349117E083A; Wed, 5 Feb 2025 13:51:14 +0100 (CET) Date: Wed, 5 Feb 2025 13:51:07 +0100 From: Boris Brezillon To: "Rob Herring (Arm)" Cc: Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?UTF-8?B?QmrDtnJu?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Beata Michalska , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH] drm/panthor: Convert IOCTL defines to an enum Message-ID: <20250205135107.50223e7a@collabora.com> In-Reply-To: <20250204232824.3819437-1-robh@kernel.org> References: <20250204232824.3819437-1-robh@kernel.org> Organization: Collabora X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 4 Feb 2025 17:28:24 -0600 "Rob Herring (Arm)" wrote: > Use an enum instead of #defines for panthor IOCTLs. This allows the > header to be used with Rust code as bindgen can't handle complex > defines. > > Cc: Beata Michalska > Signed-off-by: Rob Herring (Arm) Acked-by: Boris Brezillon > --- > include/uapi/drm/panthor_drm.h | 86 +++++++++++++++++----------------- > 1 file changed, 44 insertions(+), 42 deletions(-) > > diff --git a/include/uapi/drm/panthor_drm.h b/include/uapi/drm/panthor_drm.h > index b99763cbae48..97e2c4510e69 100644 > --- a/include/uapi/drm/panthor_drm.h > +++ b/include/uapi/drm/panthor_drm.h > @@ -129,48 +129,6 @@ enum drm_panthor_ioctl_id { > DRM_PANTHOR_TILER_HEAP_DESTROY, > }; > > -/** > - * DRM_IOCTL_PANTHOR() - Build a Panthor IOCTL number > - * @__access: Access type. Must be R, W or RW. > - * @__id: One of the DRM_PANTHOR_xxx id. > - * @__type: Suffix of the type being passed to the IOCTL. > - * > - * Don't use this macro directly, use the DRM_IOCTL_PANTHOR_xxx > - * values instead. > - * > - * Return: An IOCTL number to be passed to ioctl() from userspace. > - */ > -#define DRM_IOCTL_PANTHOR(__access, __id, __type) \ > - DRM_IO ## __access(DRM_COMMAND_BASE + DRM_PANTHOR_ ## __id, \ > - struct drm_panthor_ ## __type) > - > -#define DRM_IOCTL_PANTHOR_DEV_QUERY \ > - DRM_IOCTL_PANTHOR(WR, DEV_QUERY, dev_query) > -#define DRM_IOCTL_PANTHOR_VM_CREATE \ > - DRM_IOCTL_PANTHOR(WR, VM_CREATE, vm_create) > -#define DRM_IOCTL_PANTHOR_VM_DESTROY \ > - DRM_IOCTL_PANTHOR(WR, VM_DESTROY, vm_destroy) > -#define DRM_IOCTL_PANTHOR_VM_BIND \ > - DRM_IOCTL_PANTHOR(WR, VM_BIND, vm_bind) > -#define DRM_IOCTL_PANTHOR_VM_GET_STATE \ > - DRM_IOCTL_PANTHOR(WR, VM_GET_STATE, vm_get_state) > -#define DRM_IOCTL_PANTHOR_BO_CREATE \ > - DRM_IOCTL_PANTHOR(WR, BO_CREATE, bo_create) > -#define DRM_IOCTL_PANTHOR_BO_MMAP_OFFSET \ > - DRM_IOCTL_PANTHOR(WR, BO_MMAP_OFFSET, bo_mmap_offset) > -#define DRM_IOCTL_PANTHOR_GROUP_CREATE \ > - DRM_IOCTL_PANTHOR(WR, GROUP_CREATE, group_create) > -#define DRM_IOCTL_PANTHOR_GROUP_DESTROY \ > - DRM_IOCTL_PANTHOR(WR, GROUP_DESTROY, group_destroy) > -#define DRM_IOCTL_PANTHOR_GROUP_SUBMIT \ > - DRM_IOCTL_PANTHOR(WR, GROUP_SUBMIT, group_submit) > -#define DRM_IOCTL_PANTHOR_GROUP_GET_STATE \ > - DRM_IOCTL_PANTHOR(WR, GROUP_GET_STATE, group_get_state) > -#define DRM_IOCTL_PANTHOR_TILER_HEAP_CREATE \ > - DRM_IOCTL_PANTHOR(WR, TILER_HEAP_CREATE, tiler_heap_create) > -#define DRM_IOCTL_PANTHOR_TILER_HEAP_DESTROY \ > - DRM_IOCTL_PANTHOR(WR, TILER_HEAP_DESTROY, tiler_heap_destroy) > - > /** > * DOC: IOCTL arguments > */ > @@ -1019,6 +977,50 @@ struct drm_panthor_tiler_heap_destroy { > __u32 pad; > }; > > +/** > + * DRM_IOCTL_PANTHOR() - Build a Panthor IOCTL number > + * @__access: Access type. Must be R, W or RW. > + * @__id: One of the DRM_PANTHOR_xxx id. > + * @__type: Suffix of the type being passed to the IOCTL. > + * > + * Don't use this macro directly, use the DRM_IOCTL_PANTHOR_xxx > + * values instead. > + * > + * Return: An IOCTL number to be passed to ioctl() from userspace. > + */ > +#define DRM_IOCTL_PANTHOR(__access, __id, __type) \ > + DRM_IO ## __access(DRM_COMMAND_BASE + DRM_PANTHOR_ ## __id, \ > + struct drm_panthor_ ## __type) > + > +enum { > + DRM_IOCTL_PANTHOR_DEV_QUERY = > + DRM_IOCTL_PANTHOR(WR, DEV_QUERY, dev_query), > + DRM_IOCTL_PANTHOR_VM_CREATE = > + DRM_IOCTL_PANTHOR(WR, VM_CREATE, vm_create), > + DRM_IOCTL_PANTHOR_VM_DESTROY = > + DRM_IOCTL_PANTHOR(WR, VM_DESTROY, vm_destroy), > + DRM_IOCTL_PANTHOR_VM_BIND = > + DRM_IOCTL_PANTHOR(WR, VM_BIND, vm_bind), > + DRM_IOCTL_PANTHOR_VM_GET_STATE = > + DRM_IOCTL_PANTHOR(WR, VM_GET_STATE, vm_get_state), > + DRM_IOCTL_PANTHOR_BO_CREATE = > + DRM_IOCTL_PANTHOR(WR, BO_CREATE, bo_create), > + DRM_IOCTL_PANTHOR_BO_MMAP_OFFSET = > + DRM_IOCTL_PANTHOR(WR, BO_MMAP_OFFSET, bo_mmap_offset), > + DRM_IOCTL_PANTHOR_GROUP_CREATE = > + DRM_IOCTL_PANTHOR(WR, GROUP_CREATE, group_create), > + DRM_IOCTL_PANTHOR_GROUP_DESTROY = > + DRM_IOCTL_PANTHOR(WR, GROUP_DESTROY, group_destroy), > + DRM_IOCTL_PANTHOR_GROUP_SUBMIT = > + DRM_IOCTL_PANTHOR(WR, GROUP_SUBMIT, group_submit), > + DRM_IOCTL_PANTHOR_GROUP_GET_STATE = > + DRM_IOCTL_PANTHOR(WR, GROUP_GET_STATE, group_get_state), > + DRM_IOCTL_PANTHOR_TILER_HEAP_CREATE = > + DRM_IOCTL_PANTHOR(WR, TILER_HEAP_CREATE, tiler_heap_create), > + DRM_IOCTL_PANTHOR_TILER_HEAP_DESTROY = > + DRM_IOCTL_PANTHOR(WR, TILER_HEAP_DESTROY, tiler_heap_destroy), > +}; > + > #if defined(__cplusplus) > } > #endif