From: I Hsin Cheng <richard120310@gmail.com>
To: pmladek@suse.com
Cc: rostedt@goodmis.org, andriy.shevchenko@linux.intel.com,
linux@rasmusvillemoes.dk, senozhatsky@chromium.org,
akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
jserv@ccns.ncku.edu.tw, shuah@kernel.org,
I Hsin Cheng <richard120310@gmail.com>
Subject: [PATCH] vsprintf: Drop unused assignment of fmt.state
Date: Thu, 6 Feb 2025 01:25:07 +0800 [thread overview]
Message-ID: <20250205172508.55358-1-richard120310@gmail.com> (raw)
Remove unused assignment of "fmt.state", in both cases the value of
"fmt.state" will be overwritten by either "FORMAT_STATE_PRECISION" or
"FORMAT_STATE_NUM", the value "FORMAT_STATE_NONE" isn't going to be used
after the assignment.
Signed-off-by: I Hsin Cheng <richard120310@gmail.com>
---
lib/vsprintf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index 56fe96319292..400299465875 100644
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -2569,7 +2569,7 @@ struct fmt format_decode(struct fmt fmt, struct printf_spec *spec)
spec->field_width = -spec->field_width;
spec->flags |= LEFT;
}
- fmt.state = FORMAT_STATE_NONE;
+
goto precision;
}
@@ -2578,7 +2578,7 @@ struct fmt format_decode(struct fmt fmt, struct printf_spec *spec)
if (spec->precision < 0)
spec->precision = 0;
- fmt.state = FORMAT_STATE_NONE;
+
goto qualifier;
}
--
2.43.0
next reply other threads:[~2025-02-05 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 17:25 I Hsin Cheng [this message]
2025-02-06 15:32 ` [PATCH] vsprintf: Drop unused assignment of fmt.state Andy Shevchenko
2025-02-10 8:15 ` I Hsin Cheng
2025-02-10 13:09 ` Petr Mladek
2025-02-10 15:08 ` Andy Shevchenko
2025-02-12 12:29 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250205172508.55358-1-richard120310@gmail.com \
--to=richard120310@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jserv@ccns.ncku.edu.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox