From: kernel test robot <lkp@intel.com>
To: Joe Damato <jdamato@fastly.com>, netdev@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, pabeni@redhat.com,
edumazet@google.com, sridhar.samudrala@intel.com,
Joe Damato <jdamato@fastly.com>, Jakub Kicinski <kuba@kernel.org>,
Simon Horman <horms@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
Mina Almasry <almasrymina@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3] netdev-genl: Elide napi_id when not present
Date: Wed, 5 Feb 2025 17:22:21 +0800 [thread overview]
Message-ID: <202502051756.62x7XJ1n-lkp@intel.com> (raw)
In-Reply-To: <20250204192724.199209-1-jdamato@fastly.com>
Hi Joe,
kernel test robot noticed the following build warnings:
[auto build test WARNING on c2933b2befe25309f4c5cfbea0ca80909735fd76]
url: https://github.com/intel-lab-lkp/linux/commits/Joe-Damato/netdev-genl-Elide-napi_id-when-not-present/20250205-033024
base: c2933b2befe25309f4c5cfbea0ca80909735fd76
patch link: https://lore.kernel.org/r/20250204192724.199209-1-jdamato%40fastly.com
patch subject: [PATCH net-next v3] netdev-genl: Elide napi_id when not present
config: i386-buildonly-randconfig-004-20250205 (https://download.01.org/0day-ci/archive/20250205/202502051756.62x7XJ1n-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250205/202502051756.62x7XJ1n-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502051756.62x7XJ1n-lkp@intel.com/
All warnings (new ones prefixed by >>):
net/core/netdev-genl.c: In function 'netdev_nl_queue_fill_one':
>> net/core/netdev-genl.c:380:30: warning: variable 'txq' set but not used [-Wunused-but-set-variable]
380 | struct netdev_queue *txq;
| ^~~
vim +/txq +380 net/core/netdev-genl.c
4e43e696a7aeb2 Joe Damato 2025-02-04 373
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 374 static int
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 375 netdev_nl_queue_fill_one(struct sk_buff *rsp, struct net_device *netdev,
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 376 u32 q_idx, u32 q_type, const struct genl_info *info)
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 377 {
d0caf9876a1c9f Mina Almasry 2024-09-10 378 struct net_devmem_dmabuf_binding *binding;
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 379 struct netdev_rx_queue *rxq;
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 @380 struct netdev_queue *txq;
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 381 void *hdr;
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 382
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 383 hdr = genlmsg_iput(rsp, info);
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 384 if (!hdr)
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 385 return -EMSGSIZE;
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 386
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 387 if (nla_put_u32(rsp, NETDEV_A_QUEUE_ID, q_idx) ||
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 388 nla_put_u32(rsp, NETDEV_A_QUEUE_TYPE, q_type) ||
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 389 nla_put_u32(rsp, NETDEV_A_QUEUE_IFINDEX, netdev->ifindex))
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 390 goto nla_put_failure;
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 391
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 392 switch (q_type) {
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 393 case NETDEV_QUEUE_TYPE_RX:
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 394 rxq = __netif_get_rx_queue(netdev, q_idx);
4e43e696a7aeb2 Joe Damato 2025-02-04 395 if (nla_put_napi_id(rsp, rxq->napi))
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 396 goto nla_put_failure;
d0caf9876a1c9f Mina Almasry 2024-09-10 397
d0caf9876a1c9f Mina Almasry 2024-09-10 398 binding = rxq->mp_params.mp_priv;
d0caf9876a1c9f Mina Almasry 2024-09-10 399 if (binding &&
d0caf9876a1c9f Mina Almasry 2024-09-10 400 nla_put_u32(rsp, NETDEV_A_QUEUE_DMABUF, binding->id))
d0caf9876a1c9f Mina Almasry 2024-09-10 401 goto nla_put_failure;
d0caf9876a1c9f Mina Almasry 2024-09-10 402
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 403 break;
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 404 case NETDEV_QUEUE_TYPE_TX:
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 405 txq = netdev_get_tx_queue(netdev, q_idx);
4e43e696a7aeb2 Joe Damato 2025-02-04 406 if (nla_put_napi_id(rsp, rxq->napi))
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 407 goto nla_put_failure;
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 408 }
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 409
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 410 genlmsg_end(rsp, hdr);
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 411
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 412 return 0;
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 413
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 414 nla_put_failure:
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 415 genlmsg_cancel(rsp, hdr);
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 416 return -EMSGSIZE;
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 417 }
6b6171db7fc8f7 Amritha Nambiar 2023-12-01 418
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2025-02-05 9:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 19:27 [PATCH net-next v3] netdev-genl: Elide napi_id when not present Joe Damato
2025-02-05 9:22 ` kernel test robot
2025-02-05 9:22 ` kernel test robot [this message]
2025-02-05 19:11 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202502051756.62x7XJ1n-lkp@intel.com \
--to=lkp@intel.com \
--cc=almasrymina@google.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox