Re: [PATCH] perf/core: move all of the pmu devices into their own location

Vince Weaver
2025-02-05T15:06:58Z

On Wed, 5 Feb 2025, Greg Kroah-Hartman wrote:

> On Tue, Feb 04, 2025 at 08:21:17PM -0500, Vince Weaver wrote:
> >
> > it doesn't matter if it's a one line change, your proposed change breaks
> > userspace.
>
> It breaks broken userspace :)

no, it breaks working code that's been working for 15 years, apparently on
some whim by you.

I thought we didn't break userspace.

> > I thought the rule was Linux didn't break userspace.
> > Has that changed recently?
>
> No, which is why I am working to fix these tools so that it will not be
> broken.

that... is some impressive doublethink.

> > libpfm4/PAPI are widely used and deployed and in some cases possibly
> > statically linked into other projects. It will take years for the change
> > to filter out to all users.
>
> Great, as it is easy to get this type of fix into the stable kernels,
> and then fix these tools, by the time those old systems eventually
> update to a newer kernel version, it should "just work".

no, that is the worst case scenario. PAPI is installed on older systems,
often custom non-vendor packages. So if you get this into stable then
these older RHEL systems the kernel will be updated suddenly breaking the
users with no warning.

Even if we manage to get a change into libpfm4 and PAPI it will probably
be months before the next stable release, and again people tend not to
upgrade PAPI releases that often.

> I'm fixing up the bug where all of these devices accidentally got dumped
> into the root of the device tree in the system.

is this a "bug" or just you shuffling around files for no reason?

> Again, /sys/devices/ is NEVER guaranteed to have specific placement,
> that's the whole point of sysfs in the first place. We can, and do,
> move devices around in there all the time (even every other boot), it's
> just that some tools accidentally didn't realize this and now need to be
> fixed.

great. Slap a note about this happening in the appropriate "deprecated"
file with a timeline of 5 years out or whatever, and then when that comes
around then send your patch.

Vince Weaver
vincent.weaver@maine.edu