Re: [PATCH] perf/core: move all of the pmu devices into their own location

Greg Kroah-Hartman
2025-02-05T05:45:49Z

On Tue, Feb 04, 2025 at 08:21:17PM -0500, Vince Weaver wrote:
> On Tue, 4 Feb 2025, Greg Kroah-Hartman wrote:
>
> > On Tue, Feb 04, 2025 at 09:49:55AM -0800, Ian Rogers wrote:
> > > On Tue, Feb 4, 2025 at 9:12 AM Greg Kroah-Hartman
> > > <gregkh@linuxfoundation.org> wrote:
> > > >
> > > > On Tue, Feb 04, 2025 at 11:41:38AM -0500, Vince Weaver wrote:
> > > > > On Tue, 4 Feb 2025, Greg Kroah-Hartman wrote:
> > > > >
> > > > > >
> > > > > > It seems that the majority of the perf code IS looking in the correct
> > > > > > place, just mem-events.c seemed wrong.
> > > > >
> > > > > I hate to tell you, but other places in userspace are depending on the
> > > > > current setup. libpfm4, used by PAPI, is looking directly in /sys/devices
> > > > > for pmus and will break with the changes you are planning.
> > > >
> > > > Then that too needs to be fixed, sorry. Again, devices can, and will,
> > > > move around in /sys/devices/ you can never hard-code any paths there.
> > > > Any userspace code must ALWAYS be able to handle that, that's a sysfs
> > > > requirement.
> > > >
> > > > And do you have a link to the source for that code? Good news is that
> > > > if the code is fixed in userspace, it will work for any kernel (old or
> > > > new).
> > >
> > > +Stephane Eranian
> > >
> > > I see use of /sys/devices in at least:
> > > https://sourceforge.net/p/perfmon2/libpfm4/ci/master/tree/lib/pfmlib_perf_event_pmu.c
> > > I imagine it isn't a big job to clean it up.
> >
> > Nope, all that has to happen is this line:
> > snprintf(buf, PATH_MAX, "/sys/devices/%s/events/%s", e->pmu ? e->pmu : "cpu", e->name);
> > be changed to:
> > snprintf(buf, PATH_MAX, "/sys/bus/event_source/devices/%s/events/%s", e->pmu ? e->pmu : "cpu", e->name);
>
> it doesn't matter if it's a one line change, your proposed change breaks
> userspace.

It breaks broken userspace :)

> I thought the rule was Linux didn't break userspace.
> Has that changed recently?

No, which is why I am working to fix these tools so that it will not be
broken.

> libpfm4/PAPI are widely used and deployed and in some cases possibly
> statically linked into other projects. It will take years for the change
> to filter out to all users.

Great, as it is easy to get this type of fix into the stable kernels,
and then fix these tools, by the time those old systems eventually
update to a newer kernel version, it should "just work".

> Is there a technical reason for this proposed change of yours, or are you
> just arbitrarily breaking userspace programs because you think /sys looks
> cluttered to your personal taste?

I'm fixing up the bug where all of these devices accidentally got dumped
into the root of the device tree in the system.

Again, /sys/devices/ is NEVER guaranteed to have specific placement,
that's the whole point of sysfs in the first place. We can, and do,
move devices around in there all the time (even every other boot), it's
just that some tools accidentally didn't realize this and now need to be
fixed.

This "grey area" between the kernel and userspace of sysfs (and other
virtual filesystems), always gets tweaked and changed over time. sysfs
makes it much simpler to make those changes in relation to other
filesystems like /proc/ which is why it was designed this way in the
first place.

thanks,

greg k-h