From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 012ED199B9; Thu, 6 Feb 2025 13:57:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738850241; cv=none; b=iR2BFvPAgsWkkwXp4wWDsdDqFRZ76enSMRH21KbAIktIbqRLTfhzdfdH9uRyAK7ExL3VxbDeXRhyYHTO6fU+QUMZ7+7cVWWi1rLTYE9lUeswZGicGbTfHqMQeLnRumeJsfstjb/qXxNOcE+qcenwiCiKcuUDkOAnCAUMeXweOBM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738850241; c=relaxed/simple; bh=LxYhiBiaZHBVR5Gszv7w/Tef4B8mfeE8hfjbsuT8Pxw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DsfeTezd8Gnj+C2l79dMoGKgTtZ+MgCy5f81/kkHSsOn3FyJoLS+a11VuXNWP81DhJWelCjYrMqe6udTFLQbf+kfXpa/FHcR2eSm4nqWgXZVePfVm/skUc0i/vk8OHufI34rfssZWrPoaj8JZ+xWPxMC/EoiNW3SUC81b8Rnw/o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=dvGXW9vr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="dvGXW9vr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 26496C4CEDD; Thu, 6 Feb 2025 13:57:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738850239; bh=LxYhiBiaZHBVR5Gszv7w/Tef4B8mfeE8hfjbsuT8Pxw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dvGXW9vruqA5OZ9jMC8fhfP2uAjPcXoOle4tDfQuEYs4gH0YggZyErKDMfT9Alr2a eM95P7GIGqg7QnFhRRAzE+W4nVFhTG0MPnaMIq0kfrDtDnsTnPnE732p9gp54tbNGq B8Fy4oZMq6EKMb2DCQY0rJwuu832LoI4rM9mSqQBP8zqDnRYLZQbFBTdRG6cm7idVC NJbq4UTsyAWJ4F4uz+8Kvr6LxvoN/6g//lvxu+TR53N9R/rBaHWjuxpk02XLISHd85 0eeDmR6aSyIqlu1Id/+TWsuejTLv1d5TUfFWMJU5eZPTzkGYCQ0gbYsx4yMBKghOmc WDErRNAxO1unw== Date: Thu, 6 Feb 2025 06:57:15 -0700 From: Nathan Chancellor To: Will Deacon Cc: Catalin Marinas , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, stable@vger.kernel.org Subject: Re: [PATCH v2] arm64: Handle .ARM.attributes section in linker scripts Message-ID: <20250206135715.GA180182@ax162> References: <20250204-arm64-handle-arm-attributes-in-linker-script-v2-1-d684097f5554@kernel.org> <20250206130526.GB3204@willie-the-truck> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250206130526.GB3204@willie-the-truck> Hi Will, On Thu, Feb 06, 2025 at 01:05:26PM +0000, Will Deacon wrote: > On Tue, Feb 04, 2025 at 10:48:55AM -0700, Nathan Chancellor wrote: > > A recent LLVM commit [1] started generating an .ARM.attributes section > > similar to the one that exists for 32-bit, which results in orphan > > section warnings (or errors if CONFIG_WERROR is enabled) from the linker > > because it is not handled in the arm64 linker scripts. > > > > ld.lld: error: arch/arm64/kernel/vdso/vgettimeofday.o:(.ARM.attributes) is being placed in '.ARM.attributes' > > ld.lld: error: arch/arm64/kernel/vdso/vgetrandom.o:(.ARM.attributes) is being placed in '.ARM.attributes' > > > > ld.lld: error: vmlinux.a(lib/vsprintf.o):(.ARM.attributes) is being placed in '.ARM.attributes' > > ld.lld: error: vmlinux.a(lib/win_minmax.o):(.ARM.attributes) is being placed in '.ARM.attributes' > > ld.lld: error: vmlinux.a(lib/xarray.o):(.ARM.attributes) is being placed in '.ARM.attributes' > > > > Discard the new sections in the necessary linker scripts to resolve the > > warnings, as the kernel and vDSO do not need to retain it, similar to > > the .note.gnu.property section. > > > > Cc: stable@vger.kernel.org > > Fixes: b3e5d80d0c48 ("arm64/build: Warn on orphan section placement") > > Link: https://github.com/llvm/llvm-project/commit/ee99c4d4845db66c4daa2373352133f4b237c942 [1] > > Signed-off-by: Nathan Chancellor > > --- > > Changes in v2: > > - Discard the section instead of adding it to the final artifacts to > > mirror the .note.gnu.property section handling (Will). > > Thanks for the v2. Just a minor nit: > > > - Link to v1: https://lore.kernel.org/r/20250124-arm64-handle-arm-attributes-in-linker-script-v1-1-74135b6cf349@kernel.org > > --- > > arch/arm64/kernel/vdso/vdso.lds.S | 1 + > > arch/arm64/kernel/vmlinux.lds.S | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/arch/arm64/kernel/vdso/vdso.lds.S b/arch/arm64/kernel/vdso/vdso.lds.S > > index 4ec32e86a8da..8095fef66209 100644 > > --- a/arch/arm64/kernel/vdso/vdso.lds.S > > +++ b/arch/arm64/kernel/vdso/vdso.lds.S > > @@ -80,6 +80,7 @@ SECTIONS > > *(.data .data.* .gnu.linkonce.d.* .sdata*) > > *(.bss .sbss .dynbss .dynsbss) > > *(.eh_frame .eh_frame_hdr) > > + *(.ARM.attributes) > > } > > Can we chuck this in the earlier /DISCARD/ section along with > .note.gnu.property? i.e. Sure, I don't see why not. Do you want the comment above it updated to mention this section or should I leave it as is? > diff --git a/arch/arm64/kernel/vdso/vdso.lds.S b/arch/arm64/kernel/vdso/vdso.lds.S > index 4ec32e86a8da..47ad6944f9f0 100644 > --- a/arch/arm64/kernel/vdso/vdso.lds.S > +++ b/arch/arm64/kernel/vdso/vdso.lds.S > @@ -41,6 +41,7 @@ SECTIONS > */ > /DISCARD/ : { > *(.note.GNU-stack .note.gnu.property) > + *(.ARM.attributes) > } > .note : { *(.note.*) } :text :note > > > Will