From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AB5D22D4F8;
	Thu,  6 Feb 2025 14:28:14 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1738852094; cv=none; b=mrOiDJW5lOImIHtRJA6jBshI533TszbX8Pz04rbQqXsHMjwUgtk1taKlzd/gu8YY8puACWRlQ9LRHnCm1pVka0+6ZWun6kWfb6oadIx0YyMSPRP8yW3J1xXTckuEf/ekH25PfZ83Lz7dD3zh8+omH3jzjvOdVz/I3JAjT1ebD00=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1738852094; c=relaxed/simple;
	bh=uYGpgO24aGawl3gWDh1ZdcK2qXbzQnfvCq7tRYaL6Ws=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=gpO1ApqNFeDRE67xfj6cfU9YEaoBVhgGdQwvW7qhZSHzEzGUMI9Wg0BOoThL/tFZaYbY52LyqGtilHAa5kRhPMblp/8jV93qALcp/a76ZzjQVemm7Rc+1mjSKiYvXuvUqrlDG0Ccx28mImODH1+ws/a7Yjupyapr6NEMDEQ+8Ls=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=uEjcrTfz; arc=none smtp.client-ip=10.30.226.201
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="uEjcrTfz"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66B3EC4CEDD;
	Thu,  6 Feb 2025 14:28:13 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
	s=korg; t=1738852094;
	bh=uYGpgO24aGawl3gWDh1ZdcK2qXbzQnfvCq7tRYaL6Ws=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=uEjcrTfzA6CpPH0t/AqVezLM92pTIVxHvdj+DOVcs6UJsjLYnit9mKAB7fva3b6ta
	 10ioreUkGFgpF26sxcF2q4CBC0tfAgPbrfT/ie0bSv8nU6N8ioaPmOkgT9rFg5rdn9
	 w7X+DnbmGyHrfrhkQTve0TqL9N44IL4jH+XlL7Q4=
Date: Thu, 6 Feb 2025 06:38:21 +0100
From: Greg KH <gregkh@linuxfoundation.org>
To: Jiasheng Jiang <jiashengjiangcool@gmail.com>
Cc: markus.elfring@web.de, GR-QLogic-Storage-Upstream@marvell.com,
	James.Bottomley@hansenpartnership.com, arun.easi@cavium.com,
	bvanassche@acm.org, jhasan@marvell.com,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	manish.rangankar@cavium.com, martin.petersen@oracle.com,
	nilesh.javali@cavium.com, skashyap@marvell.com,
	stable@vger.kernel.org
Subject: Re: [PATCH 1/2] scsi: qedf: Replace kmalloc_array() with kcalloc()
Message-ID: <2025020658-backlog-riot-5faf@gregkh>
References: <d4db5506-6ace-4585-972e-6b7a6fc882a4@web.de>
 <20250206052523.16683-1-jiashengjiangcool@gmail.com>
 <20250206052523.16683-2-jiashengjiangcool@gmail.com>
 <2025020626-purist-chrome-0dd6@gregkh>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2025020626-purist-chrome-0dd6@gregkh>

On Thu, Feb 06, 2025 at 06:36:58AM +0100, Greg KH wrote:
> On Thu, Feb 06, 2025 at 05:25:22AM +0000, Jiasheng Jiang wrote:
> > Replace kmalloc_array() with kcalloc() to avoid old (dirty) data being
> > used/freed.
> 
> Used/freed where?
> 
> > 
> > Fixes: 61d8658b4a43 ("scsi: qedf: Add QLogic FastLinQ offload FCoE driver framework.")
> > Cc: <stable@vger.kernel.org> # v5.10+
> > Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
> > ---
> >  drivers/scsi/qedf/qedf_io.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c
> > index fcfc3bed02c6..d52057b97a4f 100644
> > --- a/drivers/scsi/qedf/qedf_io.c
> > +++ b/drivers/scsi/qedf/qedf_io.c
> > @@ -254,9 +254,7 @@ struct qedf_cmd_mgr *qedf_cmd_mgr_alloc(struct qedf_ctx *qedf)
> >  	}
> >  
> >  	/* Allocate pool of io_bdts - one for each qedf_ioreq */
> > -	cmgr->io_bdt_pool = kmalloc_array(num_ios, sizeof(struct io_bdt *),
> > -	    GFP_KERNEL);
> > -
> > +	cmgr->io_bdt_pool = kcalloc(num_ios, sizeof(*cmgr->io_bdt_pool), GFP_KERNEL);
> 
> This is just an array that is then properly all initialized a few lines
> below this.
> 
> So why does this need to be zeroed out at all?

Oh, I think I figured it out, but your text for the changelog is wrong,
and needs to be fixed to properly describe what is going on here.

thanks,

greg k-h