From: kernel test robot <lkp@intel.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Jeff Layton <jlayton@kernel.org>, Jan Kara <jack@suse.cz>
Subject: fs/dcache.c:2788:24-43: WARNING: atomic_dec_and_test variation before object free at line 2789.
Date: Fri, 7 Feb 2025 03:44:40 +0800 [thread overview]
Message-ID: <202502070322.IsdN65Ea-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 92514ef226f511f2ca1fb1b8752966097518edc0
commit: 95a4ccbbe596b45264af5e3a019cb920c05ccffd dissolve external_name.u into separate members
date: 10 days ago
config: alpha-randconfig-r053-20250206 (https://download.01.org/0day-ci/archive/20250207/202502070322.IsdN65Ea-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 14.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502070322.IsdN65Ea-lkp@intel.com/
cocci warnings: (new ones prefixed by >>)
>> fs/dcache.c:2788:24-43: WARNING: atomic_dec_and_test variation before object free at line 2789.
fs/dcache.c:407:13-32: WARNING: atomic_dec_and_test variation before object free at line 408.
fs/dcache.c:407:13-32: WARNING: atomic_dec_and_test variation before object free at line 416.
fs/dcache.c:368:15-34: WARNING: atomic_dec_and_test variation before object free at line 369.
vim +2788 fs/dcache.c
2774
2775 static void copy_name(struct dentry *dentry, struct dentry *target)
2776 {
2777 struct external_name *old_name = NULL;
2778 if (unlikely(dname_external(dentry)))
2779 old_name = external_name(dentry);
2780 if (unlikely(dname_external(target))) {
2781 atomic_inc(&external_name(target)->count);
2782 dentry->d_name = target->d_name;
2783 } else {
2784 dentry->d_shortname = target->d_shortname;
2785 dentry->d_name.name = dentry->d_shortname.string;
2786 dentry->d_name.hash_len = target->d_name.hash_len;
2787 }
> 2788 if (old_name && likely(atomic_dec_and_test(&old_name->count)))
> 2789 kfree_rcu(old_name, head);
2790 }
2791
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2025-02-06 19:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 19:44 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-01-28 0:19 fs/dcache.c:2788:24-43: WARNING: atomic_dec_and_test variation before object free at line 2789 kernel test robot
2026-01-28 4:55 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202502070322.IsdN65Ea-lkp@intel.com \
--to=lkp@intel.com \
--cc=jack@suse.cz \
--cc=jlayton@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox