From: Lee Jones <lee@kernel.org>
To: "Dr. David Alan Gilbert" <linux@treblig.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: max8997 cleanup bug?
Date: Fri, 7 Feb 2025 08:58:07 +0000 [thread overview]
Message-ID: <20250207085807.GE7593@google.com> (raw)
In-Reply-To: <Z6KxrcQz0JsQJ9nP@gallifrey>
On Wed, 05 Feb 2025, Dr. David Alan Gilbert wrote:
> Hi Lee,
> I noticed that:
> drivers/mfd/max8997-irq.c max8997_irq_exit
> isn't called anywhere and was about to send a deadcode patch,
> but I'm thinking it's actually a bug and it should be called.
>
> Looking at the max8998, it has basically the same function,
> and it calls it from an error path in it's max8998_i2c_probe.
> There's no equivalent call in max8997's probe.
>
> To me it looks like it probably goes after the 'err_i2c_haptic:'
> label, but I don't know the code and as far as I know I don't
> have one of the devices.
>
> Any thoughts?
I would convert to devm_request_threaded_irq() and remove it.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-02-07 8:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 0:32 max8997 cleanup bug? Dr. David Alan Gilbert
2025-02-07 8:58 ` Lee Jones [this message]
2025-02-07 15:41 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250207085807.GE7593@google.com \
--to=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox