From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C64D118FDAA; Fri, 7 Feb 2025 16:45:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738946710; cv=none; b=tjasqEphglv78tV/Qe7dg3FsmTwH31Ga7+c3dgWwa4l3N9iZsv4cHAH7FOXeso3BOFH07TBvU0zwKLj2/V8RfFgm+nat0iCK8wwOBtfIYg2lJ2qXXqFlVffZu5Krm894f7Zv5KgTNnrMZJaIZnIg8PngYwHbrejRtu3Z0aidS7M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738946710; c=relaxed/simple; bh=vZhYNhVJlENcmP350wa8xjJ2Q4xsjVpRGiaD0AjrCik=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ViOp4TGbCY3eV1Zi6UYo5r4Mg/XUOeOQ+Uu/MV+nMGWVzarhGLVz9wv8Kre3CdubjFLw2JCcFBbXPK78kPiUG+yMA0wmZsPBvYVDWLAbRvwhcLqDr2AQaCRf8fRDvMmvmnrzTRGQMWjs86oyf1QPj5jyBXZa247GNWpNJiVUWk4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=Wx9CkIbZ; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Wx9CkIbZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1738946707; bh=vZhYNhVJlENcmP350wa8xjJ2Q4xsjVpRGiaD0AjrCik=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Wx9CkIbZGlkze2Fe2FqWzWFvdFku+27oX6MLedl5eDs6eQlhZnPfy6Seo9GhFbjh3 j9ALab2XYraH7ZOd+AFrE0OCiVCWGY2giw2w+4w2c3kdpNILdhA2gJs46Y0JM0TWuo hDSgxCsrm/wIC0yd6lZkj/UGUjrJYnl8EAiudg73D/0UyoOSkBtBM91m6aAyJnwfAs iuBqusb9Y+vthwIFKJG8+ynYCjYqqs4mtYEQ3f7h8uyz2Q5cR0ehZ/W5GQTLse197z 8N+HbZNdRAQIxzd9bVExTCt9uZrQDzkRxFWEHpOEbPDVBBHYi9EpiGv0uNEIUyNk+3 3ggN5n5eEc1UA== Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 85FA117E0239; Fri, 7 Feb 2025 17:45:06 +0100 (CET) Date: Fri, 7 Feb 2025 17:44:56 +0100 From: Boris Brezillon To: Dan Carpenter Cc: Su Hui , steven.price@arm.com, liviu.dudau@arm.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch, mary.guillemard@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] drm/panthor: avoid garbage value in panthor_ioctl_dev_query() Message-ID: <20250207174456.04eeee9c@collabora.com> In-Reply-To: <01bf1bd2-2764-41a1-85aa-962f1197387f@stanley.mountain> References: <20250119025828.1168419-1-suhui@nfschina.com> <01bf1bd2-2764-41a1-85aa-962f1197387f@stanley.mountain> Organization: Collabora X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 20 Jan 2025 10:21:49 +0300 Dan Carpenter wrote: > On Sun, Jan 19, 2025 at 10:58:29AM +0800, Su Hui wrote: > > 'priorities_info' is uninitialized, and the uninitialized value is copied > > to user object when calling PANTHOR_UOBJ_SET(). Using memset to initialize > > 'priorities_info' to avoid this garbage value problem. > > > > Fixes: f70000ef2352 ("drm/panthor: Add DEV_QUERY_GROUP_PRIORITIES_INFO dev query") > > Signed-off-by: Su Hui > > Reviewed-by: Dan Carpenter Queued to drm-misc-fixes. > > How did you find this bug? > > regards, > dan carpenter >