Re: [PATCH bpf-next v2 18/26] rqspinlock: Add entry to Makefile, MAINTAINERS

kernel test robot
2025-02-07T14:15:17Z

Hi Kumar,

kernel test robot noticed the following build errors:

[auto build test ERROR on 0abff462d802a352c87b7f5e71b442b09bf9cfff]

url: https://github.com/intel-lab-lkp/linux/commits/Kumar-Kartikeya-Dwivedi/locking-Move-MCS-struct-definition-to-public-header/20250206-190258
base: 0abff462d802a352c87b7f5e71b442b09bf9cfff
patch link: https://lore.kernel.org/r/20250206105435.2159977-19-memxor%40gmail.com
patch subject: [PATCH bpf-next v2 18/26] rqspinlock: Add entry to Makefile, MAINTAINERS
config: i386-randconfig-014-20250207 (https://download.01.org/0day-ci/archive/20250207/202502072249.IXcsG9Tu-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250207/202502072249.IXcsG9Tu-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502072249.IXcsG9Tu-lkp@intel.com/

All errors (new ones prefixed by >>):

In file included from arch/x86/include/asm/rqspinlock.h:27,
from kernel/locking/rqspinlock.c:28:
include/asm-generic/rqspinlock.h:33:12: error: conflicting types for 'resilient_tas_spin_lock'; have 'int(rqspinlock_t *, u64)' {aka 'int(struct rqspinlock *, long long unsigned int)'}
33 | extern int resilient_tas_spin_lock(rqspinlock_t *lock, u64 timeout);
| ^~~~~~~~~~~~~~~~~~~~~~~
arch/x86/include/asm/rqspinlock.h:17:12: note: previous declaration of 'resilient_tas_spin_lock' with type 'int(struct qspinlock *, u64)' {aka 'int(struct qspinlock *, long long unsigned int)'}
17 | extern int resilient_tas_spin_lock(struct qspinlock *lock, u64 timeout);
| ^~~~~~~~~~~~~~~~~~~~~~~
>> kernel/locking/rqspinlock.c:293:16: error: conflicting types for 'resilient_tas_spin_lock'; have 'int(rqspinlock_t *, u64)' {aka 'int(struct rqspinlock *, long long unsigned int)'}
293 | int __lockfunc resilient_tas_spin_lock(rqspinlock_t *lock, u64 timeout)
| ^~~~~~~~~~~~~~~~~~~~~~~
arch/x86/include/asm/rqspinlock.h:17:12: note: previous declaration of 'resilient_tas_spin_lock' with type 'int(struct qspinlock *, u64)' {aka 'int(struct qspinlock *, long long unsigned int)'}
17 | extern int resilient_tas_spin_lock(struct qspinlock *lock, u64 timeout);
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/locking/rqspinlock.c:204:13: warning: 'rqspinlock_report_violation' defined but not used [-Wunused-function]
204 | static void rqspinlock_report_violation(const char *s, void *lock)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +293 kernel/locking/rqspinlock.c

65ba402b78bc5d Kumar Kartikeya Dwivedi 2025-02-06 288
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 289 /*
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 290 * Provide a test-and-set fallback for cases when queued spin lock support is
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 291 * absent from the architecture.
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 292 */
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 @293 int __lockfunc resilient_tas_spin_lock(rqspinlock_t *lock, u64 timeout)
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 294 {
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 295 struct rqspinlock_timeout ts;
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 296 int val, ret = 0;
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 297
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 298 RES_INIT_TIMEOUT(ts, timeout);
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 299 grab_held_lock_entry(lock);
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 300 retry:
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 301 val = atomic_read(&lock->val);
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 302
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 303 if (val || !atomic_try_cmpxchg(&lock->val, &val, 1)) {
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 304 if (RES_CHECK_TIMEOUT(ts, ret, ~0u)) {
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 305 lockevent_inc(rqspinlock_lock_timeout);
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 306 goto out;
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 307 }
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 308 cpu_relax();
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 309 goto retry;
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 310 }
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 311
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 312 return 0;
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 313 out:
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 314 release_held_lock_entry();
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 315 return ret;
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 316 }
7a9d3b27f7bf9c Kumar Kartikeya Dwivedi 2025-02-06 317

--
0-DAY CI Kernel Test Service