Re: [PATCH bpf-next v2 18/26] rqspinlock: Add entry to Makefile, MAINTAINERS

kernel test robot
2025-02-08T00:43:37Z

Hi Kumar,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 0abff462d802a352c87b7f5e71b442b09bf9cfff]

url: https://github.com/intel-lab-lkp/linux/commits/Kumar-Kartikeya-Dwivedi/locking-Move-MCS-struct-definition-to-public-header/20250206-190258
base: 0abff462d802a352c87b7f5e71b442b09bf9cfff
patch link: https://lore.kernel.org/r/20250206105435.2159977-19-memxor%40gmail.com
patch subject: [PATCH bpf-next v2 18/26] rqspinlock: Add entry to Makefile, MAINTAINERS
config: x86_64-randconfig-121-20250207 (https://download.01.org/0day-ci/archive/20250208/202502080835.XRxxo7P5-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250208/202502080835.XRxxo7P5-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502080835.XRxxo7P5-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> kernel/locking/rqspinlock.c:101:39: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@ got struct rqspinlock_held * @@
kernel/locking/rqspinlock.c:101:39: sparse: expected void const [noderef] __percpu *__vpp_verify
kernel/locking/rqspinlock.c:101:39: sparse: got struct rqspinlock_held *
kernel/locking/rqspinlock.c:123:39: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@ got struct rqspinlock_held * @@
kernel/locking/rqspinlock.c:123:39: sparse: expected void const [noderef] __percpu *__vpp_verify
kernel/locking/rqspinlock.c:123:39: sparse: got struct rqspinlock_held *
kernel/locking/rqspinlock.c:136:51: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@ got struct rqspinlock_held * @@
kernel/locking/rqspinlock.c:136:51: sparse: expected void const [noderef] __percpu *__vpp_verify
kernel/locking/rqspinlock.c:136:51: sparse: got struct rqspinlock_held *
kernel/locking/rqspinlock.c:206:39: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@ got struct rqspinlock_held * @@
kernel/locking/rqspinlock.c:206:39: sparse: expected void const [noderef] __percpu *__vpp_verify
kernel/locking/rqspinlock.c:206:39: sparse: got struct rqspinlock_held *
>> kernel/locking/rqspinlock.c:572:41: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected struct qnode *qnodes @@ got struct qnode [noderef] __percpu * @@
kernel/locking/rqspinlock.c:572:41: sparse: expected struct qnode *qnodes
kernel/locking/rqspinlock.c:572:41: sparse: got struct qnode [noderef] __percpu *
kernel/locking/rqspinlock.c: note: in included file:
kernel/locking/qspinlock.h:67:16: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@ got struct mcs_spinlock * @@
kernel/locking/qspinlock.h:67:16: sparse: expected void const [noderef] __percpu *__vpp_verify
kernel/locking/qspinlock.h:67:16: sparse: got struct mcs_spinlock *

vim +101 kernel/locking/rqspinlock.c

6516ce00a1482f Kumar Kartikeya Dwivedi 2025-02-06 97
6516ce00a1482f Kumar Kartikeya Dwivedi 2025-02-06 98 static noinline int check_deadlock_AA(rqspinlock_t *lock, u32 mask,
6516ce00a1482f Kumar Kartikeya Dwivedi 2025-02-06 99 struct rqspinlock_timeout *ts)
6516ce00a1482f Kumar Kartikeya Dwivedi 2025-02-06 100 {
6516ce00a1482f Kumar Kartikeya Dwivedi 2025-02-06 @101 struct rqspinlock_held *rqh = this_cpu_ptr(&rqspinlock_held_locks);
6516ce00a1482f Kumar Kartikeya Dwivedi 2025-02-06 102 int cnt = min(RES_NR_HELD, rqh->cnt);
6516ce00a1482f Kumar Kartikeya Dwivedi 2025-02-06 103
6516ce00a1482f Kumar Kartikeya Dwivedi 2025-02-06 104 /*
6516ce00a1482f Kumar Kartikeya Dwivedi 2025-02-06 105 * Return an error if we hold the lock we are attempting to acquire.
6516ce00a1482f Kumar Kartikeya Dwivedi 2025-02-06 106 * We'll iterate over max 32 locks; no need to do is_lock_released.
6516ce00a1482f Kumar Kartikeya Dwivedi 2025-02-06 107 */
6516ce00a1482f Kumar Kartikeya Dwivedi 2025-02-06 108 for (int i = 0; i < cnt - 1; i++) {
6516ce00a1482f Kumar Kartikeya Dwivedi 2025-02-06 109 if (rqh->locks[i] == lock)
6516ce00a1482f Kumar Kartikeya Dwivedi 2025-02-06 110 return -EDEADLK;
6516ce00a1482f Kumar Kartikeya Dwivedi 2025-02-06 111 }
6516ce00a1482f Kumar Kartikeya Dwivedi 2025-02-06 112 return 0;
6516ce00a1482f Kumar Kartikeya Dwivedi 2025-02-06 113 }
6516ce00a1482f Kumar Kartikeya Dwivedi 2025-02-06 114

--
0-DAY CI Kernel Test Service