Re: [PATCH net-next 1/4] unroll: add generic loop unroll helpers

Jakub Kicinski
2025-02-11T01:56:57Z

On Mon, 10 Feb 2025 21:08:19 +0000 Simon Horman wrote:
> > > This patch adds four variants of the unrolled helper. But as far as I can
> > > tell the patch-set only makes use of one of them, unrolled_count().
> > >
> > > I think it would be best if this patch only added helpers that are used.
> >
> > I thought they might help people in future.
> > I can remove them if you insist. BTW the original patch from Jose also
> > added several variants.
>
> I do slightly prefer only adding what is used.

Hm, I'm a bit on the fence. IDK how trivial it is to figure out how
to get the equivalent behavior from the compilers...

Let's keep it, if someone feels strongly I guess they could post
a patch to delete the unused variants.