From: Al Viro <viro@zeniv.linux.org.uk>
To: David Reaver <me@davidreaver.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Christian Brauner <brauner@kernel.org>,
linux-fsdevel@vger.kernel.org, cocci@inria.fr,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 0/6] debugfs: Replace dentry with an opaque handle in debugfs API
Date: Mon, 10 Feb 2025 05:53:41 +0000 [thread overview]
Message-ID: <20250210055341.GZ1977892@ZenIV> (raw)
In-Reply-To: <20250210052039.144513-1-me@davidreaver.com>
On Sun, Feb 09, 2025 at 09:20:20PM -0800, David Reaver wrote:
> Overview
> ========
>
> This patch series replaces raw dentry pointers in the debugfs API with
> an opaque wrapper struct:
>
> struct debugfs_node {
> struct dentry dentry;
> };
>
> Intermediate commits rely on "#define debugfs_node dentry" to migrate
> debugfs users without breaking the build. The final commit introduces
> the struct and updates debugfs internals accordingly.
>
> Why an RFC?
> ===========
>
> This is a large change, and I expect a few iterations -- unless this
> entire approach is NACKed of course :) Any advice is appreciated, and
> I'm particularly looking for feedback on the following:
Do not embed struct dentry into anything else.
Do not take over its lifetime rules.
For the record:
Anything of that sort is going to be vetoed.
next prev parent reply other threads:[~2025-02-10 5:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 5:20 [RFC PATCH 0/6] debugfs: Replace dentry with an opaque handle in debugfs API David Reaver
2025-02-10 5:20 ` [RFC PATCH 1/6] debugfs: Add temporary "#define debugfs_node dentry" directives David Reaver
2025-02-10 5:20 ` [RFC PATCH 2/6] debugfs: Add helper functions for debugfs_node encapsulation David Reaver
2025-02-10 5:20 ` [RFC PATCH 3/6] relay: Replace dentry with debugfs_node David Reaver
2025-02-10 5:20 ` [RFC PATCH 4/6] debugfs: Automated conversion from dentry to debugfs_node David Reaver
2025-02-10 5:20 ` [RFC PATCH 5/6] debugfs: Manual fixes for incomplete Coccinelle conversions David Reaver
2025-02-10 16:45 ` Steven Rostedt
2025-02-10 17:53 ` David Reaver
2025-02-10 5:20 ` [RFC PATCH 6/6] debugfs: Replace debugfs_node #define with struct wrapping dentry David Reaver
2025-02-10 5:58 ` Al Viro
2025-02-10 5:53 ` Al Viro [this message]
2025-02-10 7:08 ` [RFC PATCH 0/6] debugfs: Replace dentry with an opaque handle in debugfs API Greg Kroah-Hartman
2025-02-10 16:08 ` David Reaver
2025-02-10 16:53 ` Steven Rostedt
2025-02-10 17:00 ` Al Viro
2025-02-10 17:12 ` Steven Rostedt
2025-02-10 17:25 ` Steven Rostedt
2025-02-10 17:59 ` David Reaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250210055341.GZ1977892@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=brauner@kernel.org \
--cc=cocci@inria.fr \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=me@davidreaver.com \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox