Re: [RFC PATCH 5/6] debugfs: Manual fixes for incomplete Coccinelle conversions

Steven Rostedt
2025-02-10T16:45:30Z

On Sun, 9 Feb 2025 21:20:25 -0800
David Reaver <me@davidreaver.com> wrote:

> --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.h
> @@ -9,6 +9,7 @@
> #include <linux/file.h>
>
> struct intel_gt;
> +#define debugfs_node dentry
>
> #define __GT_DEBUGFS_ATTRIBUTE_FOPS(__name) \
> static const struct file_operations __name ## _fops = { \

Why are you adding these defines?

All files should be just including <linux/debugfs.h>

so that they can use either "dentry" or "debugfs_node" while you do he
conversion.

Then the last patch should just modify debugfs and debugfs.h and no other
file should be touched.

I'll comment on the last patch to explain what I was expecting to be done
that should satisfy Al.

-- Steve