From: Chen-Yu Tsai <wenst@chromium.org>
To: "Rob Herring (Arm)" <robh@kernel.org>
Cc: Lee Jones <lee@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Pankaj Dubey <pankaj.dubey@samsung.com>,
Will McVicker <willmcvicker@google.com>,
John Madieu <john.madieu.xa@bp.renesas.com>,
Nishanth Menon <nm@ti.com>, Vaishnav Achath <vaishnav.a@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: syscon: Restore device_node_to_regmap() for non-syscon nodes
Date: Mon, 10 Feb 2025 14:17:14 +0800 [thread overview]
Message-ID: <20250210061714.GA3153109@google.com> (raw)
In-Reply-To: <20250124191644.2309790-1-robh@kernel.org>
On Fri, Jan 24, 2025 at 01:16:44PM -0600, Rob Herring (Arm) wrote:
> Commit ba5095ebbc7a ("mfd: syscon: Allow syscon nodes without a
> "syscon" compatible") broke drivers which call device_node_to_regmap()
> on nodes without a "syscon" compatible. Restore the prior behavior for
> device_node_to_regmap().
>
> This also makes using device_node_to_regmap() incompatible with
> of_syscon_register_regmap() again, so add kerneldoc for
> device_node_to_regmap() and syscon_node_to_regmap() to make it clear
> how and when each one should be used.
>
> Fixes: ba5095ebbc7a ("mfd: syscon: Allow syscon nodes without a "syscon" compatible")
> Cc: Will McVicker <willmcvicker@google.com>
> Cc: John Madieu <john.madieu.xa@bp.renesas.com>
> Cc: Nishanth Menon <nm@ti.com>
> Reported-by: Vaishnav Achath <vaishnav.a@ti.com>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Tested-by: Chen-Yu Tsai <wenst@chromium.org>
This restored the power controller and everything depending on it on the
MT8183 Chromebooks.
next prev parent reply other threads:[~2025-02-10 6:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 19:16 [PATCH] mfd: syscon: Restore device_node_to_regmap() for non-syscon nodes Rob Herring (Arm)
2025-01-24 22:08 ` Nishanth Menon
2025-01-28 22:53 ` Nícolas F. R. A. Prado
2025-02-02 22:57 ` Daniel Golle
2025-02-03 13:16 ` Aw: " Frank Wunderlich
2025-02-04 9:21 ` Dhruva Gole
2025-02-07 9:00 ` Lee Jones
2025-02-10 6:17 ` Chen-Yu Tsai [this message]
2025-02-11 14:50 ` AngeloGioacchino Del Regno
2025-02-11 14:54 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250210061714.GA3153109@google.com \
--to=wenst@chromium.org \
--cc=arnd@arndb.de \
--cc=john.madieu.xa@bp.renesas.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=pankaj.dubey@samsung.com \
--cc=robh@kernel.org \
--cc=vaishnav.a@ti.com \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox