From: Eric Biggers <ebiggers@kernel.org>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H . Peter Anvin" <hpa@zytor.com>,
Sean Christopherson <seanjc@google.com>
Subject: Re: [PATCH v2] x86/fpu: make WARN_ON_FPU get fully optimized out
Date: Mon, 10 Feb 2025 08:27:51 -0800 [thread overview]
Message-ID: <20250210162751.GC1264@sol.localdomain> (raw)
In-Reply-To: <20250127224523.94300-1-ebiggers@kernel.org>
On Mon, Jan 27, 2025 at 02:45:23PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Currently WARN_ON_FPU evaluates its argument even if
> CONFIG_X86_DEBUG_FPU is disabled, which adds unnecessary instructions to
> several functions, for example kernel_fpu_begin(). Fix this by using
> BUILD_BUG_ON_INVALID(x) in the no-debug case rather than (void)(x).
>
> Fixes: 83242c515881 ("x86/fpu: Make WARN_ON_FPU() more robust in the !CONFIG_X86_DEBUG_FPU case")
> Suggested-by: Sean Christopherson <seanjc@google.com>
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
>
> v2: use BUILD_BUG_ON_INVALID() as suggested by Sean Christopherson.
>
> arch/x86/kernel/fpu/internal.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Ping. Any interest in taking this through the x86 tree?
- Eric
prev parent reply other threads:[~2025-02-10 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 22:45 [PATCH v2] x86/fpu: make WARN_ON_FPU get fully optimized out Eric Biggers
2025-02-10 16:27 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250210162751.GC1264@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox