From: Oleg Nesterov <oleg@redhat.com>
To: David Laight <david.laight.linux@gmail.com>
Cc: Alex Williamson <alex.williamson@redhat.com>,
bhelgaas@google.com, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, mitchell.augustin@canonical.com,
ilpo.jarvinen@linux.intel.com
Subject: Re: [PATCH v2] PCI: Batch BAR sizing operations
Date: Mon, 10 Feb 2025 23:46:15 +0100 [thread overview]
Message-ID: <20250210224615.GN32480@redhat.com> (raw)
In-Reply-To: <20250210221107.60d608ba@pumpkin>
On 02/10, David Laight wrote:
>
> On Mon, 10 Feb 2025 13:48:48 -0700
> Alex Williamson <alex.williamson@redhat.com> wrote:
>
> > On Mon, 10 Feb 2025 21:08:19 +0100
> > Oleg Nesterov <oleg@redhat.com> wrote:
> >
> > > On 02/10, Oleg Nesterov wrote:
> > > >
> > > > On 02/10, Alex Williamson wrote:
> > > > >
> > > > > --- a/drivers/pci/probe.c
> > > > > +++ b/drivers/pci/probe.c
> > > > > @@ -345,7 +345,8 @@ static void pci_read_bases(struct pci_dev *dev, unsigned int howmany, int rom)
>
> You probably need __always_inline to have any chance of a compile-time
> test of howmany.
Can't really comment...
But note that nobody else reported this problem, so I guess the newer
compilers are smart enough? Not that I am sure we can rely on it...
> > > >
> > > > BUILD_BUG_ON(__builtin_constant_p(howmany) && howmany > PCI_STD_NUM_BARS);
>
> statically_true(howmany > PCI_STD_NUM_BARS)
Indeed.
Oleg.
prev parent reply other threads:[~2025-02-10 22:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-20 18:21 [PATCH v2] PCI: Batch BAR sizing operations Alex Williamson
2025-01-20 22:44 ` Bjorn Helgaas
2025-01-21 19:01 ` Mitchell Augustin
2025-01-23 12:15 ` Ilpo Järvinen
2025-02-09 15:45 ` Oleg Nesterov
2025-02-10 16:36 ` Alex Williamson
2025-02-10 19:56 ` Oleg Nesterov
2025-02-10 20:08 ` Oleg Nesterov
2025-02-10 20:48 ` Alex Williamson
2025-02-10 22:11 ` David Laight
2025-02-10 22:46 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250210224615.GN32480@redhat.com \
--to=oleg@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=david.laight.linux@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mitchell.augustin@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox