From: Tamir Duberstein <tamird@gmail.com>
To: David Gow <davidgow@google.com>, Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Tamir Duberstein <tamird@gmail.com>
Subject: [PATCH v7 1/3] scanf: remove redundant debug logs
Date: Tue, 11 Feb 2025 10:13:37 -0500 [thread overview]
Message-ID: <20250211-scanf-kunit-convert-v7-1-c057f0a3d9d8@gmail.com> (raw)
In-Reply-To: <20250211-scanf-kunit-convert-v7-0-c057f0a3d9d8@gmail.com>
The test already prints the same information on failure; remove
redundant pr_debug() logs.
Signed-off-by: Tamir Duberstein <tamird@gmail.com>
---
lib/test_scanf.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/test_scanf.c b/lib/test_scanf.c
index 44f8508c9d88..07444a852fd4 100644
--- a/lib/test_scanf.c
+++ b/lib/test_scanf.c
@@ -62,10 +62,8 @@ _test(check_fn fn, const void *check_data, const char *string, const char *fmt,
#define _check_numbers_template(arg_fmt, expect, str, fmt, n_args, ap) \
do { \
- pr_debug("\"%s\", \"%s\" ->\n", str, fmt); \
for (; n_args > 0; n_args--, expect++) { \
typeof(*expect) got = *va_arg(ap, typeof(expect)); \
- pr_debug("\t" arg_fmt "\n", got); \
if (got != *expect) { \
pr_warn("vsscanf(\"%s\", \"%s\", ...) expected " arg_fmt " got " arg_fmt "\n", \
str, fmt, *expect, got); \
@@ -689,7 +687,6 @@ do { \
total_tests++; \
len = snprintf(test_buffer, BUF_SIZE, gen_fmt, expect); \
got = (fn)(test_buffer, &endp, base); \
- pr_debug(#fn "(\"%s\", %d) -> " gen_fmt "\n", test_buffer, base, got); \
if (got != (expect)) { \
fail = true; \
pr_warn(#fn "(\"%s\", %d): got " gen_fmt " expected " gen_fmt "\n", \
--
2.48.1
next prev parent reply other threads:[~2025-02-11 15:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 15:13 [PATCH v7 0/3] scanf: convert self-test to KUnit Tamir Duberstein
2025-02-11 15:13 ` Tamir Duberstein [this message]
2025-02-11 15:42 ` [PATCH v7 1/3] scanf: remove redundant debug logs Andy Shevchenko
2025-02-11 15:50 ` Tamir Duberstein
2025-02-11 15:58 ` Andy Shevchenko
2025-02-11 16:02 ` Tamir Duberstein
2025-02-11 17:15 ` Andy Shevchenko
2025-02-11 17:50 ` Tamir Duberstein
2025-02-11 15:13 ` [PATCH v7 2/3] scanf: convert self-test to KUnit Tamir Duberstein
2025-02-11 15:13 ` [PATCH v7 3/3] scanf: break kunit into test cases Tamir Duberstein
2025-02-11 15:40 ` [PATCH v7 0/3] scanf: convert self-test to KUnit Andy Shevchenko
2025-02-11 15:47 ` Tamir Duberstein
2025-02-11 15:54 ` Andy Shevchenko
2025-02-11 15:57 ` Tamir Duberstein
2025-02-11 17:17 ` Andy Shevchenko
2025-02-11 17:26 ` Tamir Duberstein
2025-02-12 16:54 ` Tamir Duberstein
2025-02-14 13:33 ` Petr Mladek
2025-02-14 15:39 ` Tamir Duberstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211-scanf-kunit-convert-v7-1-c057f0a3d9d8@gmail.com \
--to=tamird@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davidgow@google.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox