From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <purvayeshi550@gmail.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <horms@kernel.org>,
<kuba@kernel.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>,
<skhan@linuxfoundation.org>,
Kuniyuki Iwashima <kuniyu@amazon.com>
Subject: Re: [PATCH net-next v2] af_unix: Fix undefined 'other' error
Date: Tue, 11 Feb 2025 09:32:03 +0900 [thread overview]
Message-ID: <20250211003203.81463-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20250210075006.9126-1-purvayeshi550@gmail.com>
From: Purva Yeshi <purvayeshi550@gmail.com>
Date: Mon, 10 Feb 2025 13:20:06 +0530
> Fix issue detected by smatch tool:
> An "undefined 'other'" error occur in __releases() annotation.
>
> Fix an undefined 'other' error in unix_wait_for_peer() caused by
> __releases(&unix_sk(other)->lock) being placed before 'other' is in
> scope. Since AF_UNIX does not use Sparse annotations, remove it to fix
> the issue.
>
> Eliminate the error without affecting functionality.
The 5 lines of the 3 sentences above have trailing double spaces.
You may want to configure your editor to highlight them.
e.g. for emacs
(setq-default show-trailing-whitespace t)
>
> Signed-off-by: Purva Yeshi <purvayeshi550@gmail.com>
Otherwise looks good.
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
next prev parent reply other threads:[~2025-02-11 0:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 7:50 [PATCH net-next v2] af_unix: Fix undefined 'other' error Purva Yeshi
2025-02-10 17:50 ` Joe Damato
2025-02-11 0:32 ` Kuniyuki Iwashima [this message]
2025-02-12 14:24 ` Purva Yeshi
2025-02-12 18:48 ` Jakub Kicinski
2025-02-13 7:44 ` Purva Yeshi
2025-02-15 17:24 ` Simon Horman
2025-02-16 19:33 ` Dan Carpenter
2025-02-17 11:15 ` Simon Horman
2025-02-17 14:14 ` Dan Carpenter
2025-02-18 13:21 ` Simon Horman
2025-02-18 13:37 ` Purva Yeshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211003203.81463-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=purvayeshi550@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox