public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Magnus Lindholm <linmag7@gmail.com>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Sasha Levin <sashal@kernel.org>,
	mdr@sgi.com, James.Bottomley@HansenPartnership.com,
	linux-scsi@vger.kernel.org
Subject: [PATCH AUTOSEL 6.6 10/15] scsi: qla1280: Fix kernel oops when debug level > 2
Date: Mon, 10 Feb 2025 20:31:30 -0500	[thread overview]
Message-ID: <20250211013136.4098219-10-sashal@kernel.org> (raw)
In-Reply-To: <20250211013136.4098219-1-sashal@kernel.org>

From: Magnus Lindholm <linmag7@gmail.com>

[ Upstream commit 5233e3235dec3065ccc632729675575dbe3c6b8a ]

A null dereference or oops exception will eventually occur when qla1280.c
driver is compiled with DEBUG_QLA1280 enabled and ql_debug_level > 2.  I
think its clear from the code that the intention here is sg_dma_len(s) not
length of sg_next(s) when printing the debug info.

Signed-off-by: Magnus Lindholm <linmag7@gmail.com>
Link: https://lore.kernel.org/r/20250125095033.26188-1-linmag7@gmail.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/scsi/qla1280.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c
index 6e5e89aaa283b..74b23c43af3ea 100644
--- a/drivers/scsi/qla1280.c
+++ b/drivers/scsi/qla1280.c
@@ -2866,7 +2866,7 @@ qla1280_64bit_start_scsi(struct scsi_qla_host *ha, struct srb * sp)
 			dprintk(3, "S/G Segment phys_addr=%x %x, len=0x%x\n",
 				cpu_to_le32(upper_32_bits(dma_handle)),
 				cpu_to_le32(lower_32_bits(dma_handle)),
-				cpu_to_le32(sg_dma_len(sg_next(s))));
+				cpu_to_le32(sg_dma_len(s)));
 			remseg--;
 		}
 		dprintk(5, "qla1280_64bit_start_scsi: Scatter/gather "
-- 
2.39.5


  parent reply	other threads:[~2025-02-11  1:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-11  1:31 [PATCH AUTOSEL 6.6 01/15] nvme-fc: go straight to connecting state when initializing Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 02/15] nvme-fc: do not ignore connectivity loss during connecting Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 03/15] hrtimers: Mark is_migration_base() with __always_inline Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 04/15] powercap: call put_device() on an error path in powercap_register_control_type() Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 05/15] iscsi_ibft: Fix UBSAN shift-out-of-bounds warning in ibft_attr_show_nic() Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 06/15] sched/debug: Provide slice length for fair tasks Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 07/15] platform/x86/intel: pmc: fix ltr decode in pmc_core_ltr_show() Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 08/15] scsi: core: Use GFP_NOIO to avoid circular locking dependency Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 09/15] scsi: ufs: core: Fix error return with query response Sasha Levin
2025-02-11  1:31 ` Sasha Levin [this message]
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 11/15] Revert "drm/amd/display: Use HW lock mgr for PSR1" Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 12/15] ACPI: resource: IRQ override for Eluktronics MECH-17 Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 13/15] smb: client: fix noisy when tree connecting to DFS interlink targets Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 14/15] alpha/elf: Fix misc/setarch test of util-linux by removing 32bit support Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 15/15] vboxsf: fix building with GCC 15 Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250211013136.4098219-10-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linmag7@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mdr@sgi.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox