public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Seunghui Lee <sh043.lee@samsung.com>,
	Bean Huo <beanhuo@micron.com>,
	Bart Van Assche <bvanassche@acm.org>,
	"Martin K . Petersen" <martin.petersen@oracle.com>,
	Sasha Levin <sashal@kernel.org>,
	James.Bottomley@HansenPartnership.com, avri.altman@wdc.com,
	peter.wang@mediatek.com, manivannan.sadhasivam@linaro.org,
	ahalaney@redhat.com, linux-scsi@vger.kernel.org
Subject: [PATCH AUTOSEL 6.6 09/15] scsi: ufs: core: Fix error return with query response
Date: Mon, 10 Feb 2025 20:31:29 -0500	[thread overview]
Message-ID: <20250211013136.4098219-9-sashal@kernel.org> (raw)
In-Reply-To: <20250211013136.4098219-1-sashal@kernel.org>

From: Seunghui Lee <sh043.lee@samsung.com>

[ Upstream commit 1a78a56ea65252bb089e0daace989167227f2d31 ]

There is currently no mechanism to return error from query responses.
Return the error and print the corresponding error message with it.

Signed-off-by: Seunghui Lee <sh043.lee@samsung.com>
Link: https://lore.kernel.org/r/20250118023808.24726-1-sh043.lee@samsung.com
Reviewed-by: Bean Huo <beanhuo@micron.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/ufs/core/ufshcd.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 0ac0b6aaf9c62..e843f69b8d3a0 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -3013,8 +3013,13 @@ ufshcd_dev_cmd_completion(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
 	case UPIU_TRANSACTION_QUERY_RSP: {
 		u8 response = lrbp->ucd_rsp_ptr->header.response;
 
-		if (response == 0)
+		if (response == 0) {
 			err = ufshcd_copy_query_response(hba, lrbp);
+		} else {
+			err = -EINVAL;
+			dev_err(hba->dev, "%s: unexpected response in Query RSP: %x\n",
+					__func__, response);
+		}
 		break;
 	}
 	case UPIU_TRANSACTION_REJECT_UPIU:
-- 
2.39.5


  parent reply	other threads:[~2025-02-11  1:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-11  1:31 [PATCH AUTOSEL 6.6 01/15] nvme-fc: go straight to connecting state when initializing Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 02/15] nvme-fc: do not ignore connectivity loss during connecting Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 03/15] hrtimers: Mark is_migration_base() with __always_inline Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 04/15] powercap: call put_device() on an error path in powercap_register_control_type() Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 05/15] iscsi_ibft: Fix UBSAN shift-out-of-bounds warning in ibft_attr_show_nic() Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 06/15] sched/debug: Provide slice length for fair tasks Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 07/15] platform/x86/intel: pmc: fix ltr decode in pmc_core_ltr_show() Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 08/15] scsi: core: Use GFP_NOIO to avoid circular locking dependency Sasha Levin
2025-02-11  1:31 ` Sasha Levin [this message]
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 10/15] scsi: qla1280: Fix kernel oops when debug level > 2 Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 11/15] Revert "drm/amd/display: Use HW lock mgr for PSR1" Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 12/15] ACPI: resource: IRQ override for Eluktronics MECH-17 Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 13/15] smb: client: fix noisy when tree connecting to DFS interlink targets Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 14/15] alpha/elf: Fix misc/setarch test of util-linux by removing 32bit support Sasha Levin
2025-02-11  1:31 ` [PATCH AUTOSEL 6.6 15/15] vboxsf: fix building with GCC 15 Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250211013136.4098219-9-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=ahalaney@redhat.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=martin.petersen@oracle.com \
    --cc=peter.wang@mediatek.com \
    --cc=sh043.lee@samsung.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox