Re: [PATCH v9 03/12] x86/mm: consolidate full flush threshold decision

Rik van Riel
2025-02-10T19:15:21Z

On Fri, 2025-02-07 at 15:50 +0100, Brendan Jackman wrote:
> On Thu, 6 Feb 2025 at 05:45, Rik van Riel <riel@surriel.com> wrote:
> > @@ -1276,7 +1282,7 @@ void arch_tlbbatch_flush(struct
> > arch_tlbflush_unmap_batch *batch)
> >
> >         int cpu = get_cpu();
> >
> > -       info = get_flush_tlb_info(NULL, 0, TLB_FLUSH_ALL, 0, false,
> > +       info = get_flush_tlb_info(NULL, 0, TLB_FLUSH_ALL,
> > PAGE_SHIFT, false,
> >                                   TLB_GENERATION_INVALID);
>
> [Why] do we need this change? If it's necessary here, why isn't it
> needed everywhere else that does TLB_FLUSH_ALL too, like
> flush_tlb_mm()?
>
You are right, we do not actually need this.

I'll drop this for v10

--
All Rights Reversed.