Re: [PATCH RESEND 2/5] leds: leds-st1202: initialize hardware before DT node child operations

Manuel Fombuena
2025-02-12T15:15:17Z

On Tue, 11 Feb 2025, Lee Jones wrote:

> On Sat, 01 Feb 2025, Manuel Fombuena wrote:
>
> > Arguably, there are more chances of errors occurring during the
> > initialization of the hardware, so this should complete successfully
> > before the DT node childreen are initialized.
>
> Okay. And you're sure nothing in Setup needs the DT info?

Yes, st1202_setup() doesn't require anything previously done in
st1202_dt_init() to do its thing.

Additionally, I am not just relying on reviewing the code. I am also
carrying out real-world testing on a device I use daily and it works
either way.

--
Manuel Fombuena