From: Peter Zijlstra <peterz@infradead.org>
To: Gabriele Monaco <gmonaco@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-trace-kernel@vger.kernel.org,
Juri Lelli <juri.lelli@redhat.com>
Subject: Re: [PATCH v1 03/11] sched: Add sched tracepoints for RV task model
Date: Tue, 11 Feb 2025 15:37:07 +0100 [thread overview]
Message-ID: <20250211143707.GH29593@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <56aad1c92224c624f7404c4ef6076a6ec7299b13.camel@redhat.com>
On Tue, Feb 11, 2025 at 01:54:44PM +0100, Gabriele Monaco wrote:
> > > +void do_trace_set_current_state(int state_value)
> > > +{
> > > + trace_sched_set_state_tp(current, current->__state, state_value);
> >
> > Should this be:
> >
> > __do_trace_sched_set_state_tp() ?
> >
>
> Mmh, you mean avoiding the static_branch_unlikely in the helper
> function, since it's supposed to be used before calling it?
Yep, seems pointless to repeat that.
> > > +}
> > > +EXPORT_SYMBOL(do_trace_set_current_state);
> >
> > _GPL
> >
>
> I'm absolutely not against this change but, out of curiosity, would
> that imply non-GPL modules are not going to be able to sleep going
> forward? At least not using this pattern.
Bah, you're right. Killing non-GPL modules seems like a worthy goal
though, but perhaps another day ;-)
next prev parent reply other threads:[~2025-02-11 14:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 7:46 [PATCH v1 00/11] rv: Add scheduler specification monitors Gabriele Monaco
2025-02-11 7:46 ` [PATCH v1 01/11] tracing: Fix DECLARE_TRACE_CONDITION Gabriele Monaco
2025-02-11 7:46 ` [PATCH v1 02/11] rv: Add license identifiers to monitor files Gabriele Monaco
2025-02-11 7:46 ` [PATCH v1 03/11] sched: Add sched tracepoints for RV task model Gabriele Monaco
2025-02-11 11:03 ` Peter Zijlstra
2025-02-11 12:54 ` Gabriele Monaco
2025-02-11 14:37 ` Peter Zijlstra [this message]
2025-02-11 7:46 ` [PATCH v1 04/11] rv: Add option for nested monitors and include sched Gabriele Monaco
2025-02-11 7:46 ` [PATCH v1 05/11] rv: Add sco and tss per-cpu monitors Gabriele Monaco
2025-02-11 7:46 ` [PATCH v1 06/11] rv: Add snroc per-task monitor Gabriele Monaco
2025-02-11 7:46 ` [PATCH v1 07/11] rv: Add scpd, snep and sncid per-cpu monitors Gabriele Monaco
2025-02-11 7:46 ` [PATCH v1 08/11] tools/rv: Add support for nested monitors Gabriele Monaco
2025-02-11 7:46 ` [PATCH v1 09/11] verification/dot2k: " Gabriele Monaco
2025-02-11 7:46 ` [PATCH v1 10/11] Documentation/rv: Add docs for the sched monitors Gabriele Monaco
2025-02-11 7:46 ` [PATCH v1 11/11] tools/rv: Allow rv list to filter for container Gabriele Monaco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211143707.GH29593@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=gmonaco@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).