From: Lee Jones <lee@kernel.org>
To: j.ne@posteo.net
Cc: Pavel Machek <pavel@ucw.cz>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Davis <afd@ti.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: leds: Allow differently named multicolor leds
Date: Tue, 11 Feb 2025 14:43:00 +0000 [thread overview]
Message-ID: <20250211144300.GW1868108@google.com> (raw)
In-Reply-To: <20250209-multi-led-v1-1-5aebccbd2db7@posteo.net>
On Sun, 09 Feb 2025, J. Neuschäfer via B4 Relay wrote:
> From: "J. Neuschäfer" <j.ne@posteo.net>
>
> In some cases, a board may have multiple multi-leds, which can't be
> distinguished by unit address. In such cases it should be possible to
> name them differently, for example multi-led-a and multi-led-b.
> This patch adds another node name pattern to leds-class-multicolor.yaml
> to allow such names.
Which H/W needs this? Is it upstream? Where is the doc / usage?
> Signed-off-by: J. Neuschäfer <j.ne@posteo.net>
> ---
> Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
> index bb40bb9e036ee00e06d21e2321ecd5a7d471c408..c22af25b6430be71300c0e37f696cd61112ea190 100644
> --- a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml
> @@ -21,7 +21,9 @@ description: |
>
> properties:
> $nodename:
> - pattern: "^multi-led(@[0-9a-f])?$"
> + oneOf:
> + - pattern: "^multi-led(@[0-9a-f])?$"
> + - pattern: "^multi-led-.*$"
>
> color:
> description: |
>
> ---
> base-commit: 645b5c24cf8590eea322a4fd79c811817046a2e6
> change-id: 20250209-multi-led-9991e205befd
>
> Best regards,
> --
> J. Neuschäfer <j.ne@posteo.net>
>
>
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-02-11 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-09 22:06 [PATCH] dt-bindings: leds: Allow differently named multicolor leds J. Neuschäfer via B4 Relay
2025-02-11 14:43 ` Lee Jones [this message]
2025-02-11 18:50 ` J. Neuschäfer
2025-02-11 19:10 ` Krzysztof Kozlowski
2025-02-16 18:49 ` J. Neuschäfer
2025-02-11 19:11 ` Krzysztof Kozlowski
2025-02-17 10:58 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250211144300.GW1868108@google.com \
--to=lee@kernel.org \
--cc=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j.ne@posteo.net \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox