Re: [PATCH 2/3] regulator: qcom_usb_vbus: Add support for PMI8998 VBUS

Mark Brown
2025-02-12T00:09:18Z

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

On Wed, Feb 12, 2025 at 01:16:37AM +0200, Dmitry Baryshkov wrote:
> On Tue, Feb 11, 2025 at 11:49:15AM -0800, James A. MacInnes wrote:

> > + pmic_type = of_device_get_match_data(dev);
> > + if (pmic_type && strcmp(pmic_type, "pmi8998") == 0) {

> I think a traditional way is to define an enum and then use that enum
> values as match data. Or you can just add a struct with curr_table and
> get that as a match data.

Either approach works, yeah.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]