From: "James A. MacInnes" <james.a.macinnes@gmail.com>
To: linux-arm-msm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, robdclark@gmail.com,
quic_abhinavk@quicinc.com, dmitry.baryshkov@linaro.org,
sean@poorly.run, marijn.suijten@somainline.org,
airlied@gmail.com, simona@ffwll.ch,
"James A. MacInnes" <james.a.macinnes@gmail.com>
Subject: [PATCH 1/2] drm/msm/dp: Disable wide bus support for SDM845
Date: Tue, 11 Feb 2025 19:42:24 -0800 [thread overview]
Message-ID: <20250212034225.2565069-2-james.a.macinnes@gmail.com> (raw)
In-Reply-To: <20250212034225.2565069-1-james.a.macinnes@gmail.com>
SDM845 DPU hardware is rev 4.0.0 per hardware document.
Incorrect setting caused inop displayport.
Corrected by separating SDM845 to own descriptor.
Fixes: c7c412202623 ("drm/msm/dp: enable widebus on all relevant chipsets")
Signed-off-by: James A. MacInnes <james.a.macinnes@gmail.com>
---
drivers/gpu/drm/msm/dp/dp_display.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index aff51bb973eb..2cbdbf85a85c 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -126,6 +126,11 @@ static const struct msm_dp_desc msm_dp_desc_sa8775p[] = {
{}
};
+static const struct msm_dp_desc msm_dp_desc_sdm845[] = {
+ { .io_start = 0x0ae90000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported = false },
+ {}
+};
+
static const struct msm_dp_desc msm_dp_desc_sc7180[] = {
{ .io_start = 0x0ae90000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported = true },
{}
@@ -178,7 +183,7 @@ static const struct of_device_id msm_dp_dt_match[] = {
{ .compatible = "qcom,sc8180x-edp", .data = &msm_dp_desc_sc8180x },
{ .compatible = "qcom,sc8280xp-dp", .data = &msm_dp_desc_sc8280xp },
{ .compatible = "qcom,sc8280xp-edp", .data = &msm_dp_desc_sc8280xp },
- { .compatible = "qcom,sdm845-dp", .data = &msm_dp_desc_sc7180 },
+ { .compatible = "qcom,sdm845-dp", .data = &msm_dp_desc_sdm845 },
{ .compatible = "qcom,sm8350-dp", .data = &msm_dp_desc_sc7180 },
{ .compatible = "qcom,sm8650-dp", .data = &msm_dp_desc_sm8650 },
{ .compatible = "qcom,x1e80100-dp", .data = &msm_dp_desc_x1e80100 },
--
2.43.0
next prev parent reply other threads:[~2025-02-12 3:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 3:42 [PATCH 0/2] drm/msm/dp: Fix Type-C Timing James A. MacInnes
2025-02-12 3:42 ` James A. MacInnes [this message]
2025-02-12 10:03 ` [PATCH 1/2] drm/msm/dp: Disable wide bus support for SDM845 Marijn Suijten
2025-02-12 16:16 ` James A. MacInnes
2025-02-12 17:22 ` Marijn Suijten
2025-02-12 3:42 ` [PATCH 2/2] drm/msm/disp: Correct porch timing " James A. MacInnes
2025-02-12 10:13 ` Marijn Suijten
2025-02-12 16:23 ` James A. MacInnes
2025-02-12 17:15 ` Marijn Suijten
2025-02-12 19:56 ` James A. MacInnes
2025-02-12 11:20 ` [PATCH 0/2] drm/msm/dp: Fix Type-C Timing Dmitry Baryshkov
2025-02-12 16:34 ` James A. MacInnes
2025-02-12 17:24 ` Marijn Suijten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250212034225.2565069-2-james.a.macinnes@gmail.com \
--to=james.a.macinnes@gmail.com \
--cc=airlied@gmail.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox