From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DF03D1E7C19; Wed, 12 Feb 2025 16:37:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.176.79.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739378240; cv=none; b=r/mSqIFpkZGA74OtmO3MSRd1l06lf8Q1JOENUcVVxXs+qID51V5cLovyPZClHLsHjcSx4xwO382z4K4kSxuHfPk3jdkZpZ+N0V/KICYDvpuqhe0r4bGS8np3Y/vIG936JQUAoOoq4k2FeUCCXnejztMXp6LzASF0uIb9b54tpAU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739378240; c=relaxed/simple; bh=Kw8B3dUBG9Eghh1JxxFzYc5q2wSxP2wh0YJV67MTC6s=; h=Date:From:To:CC:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OpydowEciQjNNsJG0VfV6kmNnMT/TeUrj9GYIIA8r5JqEkEhr+ip6lbp8kakbxxKJKdRpWN77s0ybCjwZiJPpwvixqozgj1fdns93Hw4Ldm38X/7pIhaxLVa6NfDja5wTE1MR744b6Xm0B53uWw6h6luJKTb2Ds6YbGefepxO70= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; arc=none smtp.client-ip=185.176.79.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4YtP6g0hPbz6H7TG; Thu, 13 Feb 2025 00:34:51 +0800 (CST) Received: from frapeml500008.china.huawei.com (unknown [7.182.85.71]) by mail.maildlp.com (Postfix) with ESMTPS id 93583140136; Thu, 13 Feb 2025 00:37:16 +0800 (CST) Received: from localhost (10.203.177.66) by frapeml500008.china.huawei.com (7.182.85.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Wed, 12 Feb 2025 17:37:15 +0100 Date: Wed, 12 Feb 2025 16:37:14 +0000 From: Jonathan Cameron To: Zaid Alali CC: , , , , , , , , , , , , , , , , Subject: Re: [PATCH v3 4/9] ACPI: APEI: EINJ: Remove redundant calls to einj_get_available_error_type Message-ID: <20250212163714.00002433@huawei.com> In-Reply-To: <20250210183705.1114624-5-zaidal@os.amperecomputing.com> References: <20250210183705.1114624-1-zaidal@os.amperecomputing.com> <20250210183705.1114624-5-zaidal@os.amperecomputing.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.42; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100012.china.huawei.com (7.191.174.184) To frapeml500008.china.huawei.com (7.182.85.71) On Mon, 10 Feb 2025 10:37:00 -0800 Zaid Alali wrote: > A single call to einj_get_available_error_type in init function is > sufficient to save the return value in a global variable to be used > later in various places in the code. This commit does not introduce > any functional changes, but only removing unnecessary redundant > function calls. > > Signed-off-by: Zaid Alali Seems reasonable to me. Reviewed-by: Jonathan Cameron