From: Peter Zijlstra <peterz@infradead.org>
To: Haiyue Wang <haiyuewa@163.com>
Cc: Sami Tolvanen <samitolvanen@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
"Masami Hiramatsu (Google)" <mhiramat@kernel.org>,
Gabriel de Perthuis <g2p.code@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, linux-trace-kernel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ftrace: x86: Fix a compile error about get_kernel_nofault()
Date: Thu, 13 Feb 2025 11:40:14 +0100 [thread overview]
Message-ID: <20250213104014.GD28068@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <08422aab-f4a9-4f67-84ef-82ad3663b01f@163.com>
On Thu, Feb 13, 2025 at 06:25:41PM +0800, Haiyue Wang wrote:
> It is header file include indirect :-)
>
> https://lore.kernel.org/linux-trace-kernel/20250206131711.ea536f165d5b5980b3909acd@kernel.org/T/#t
>
> File "asm-prototypes.h" is added to entry.S by 'scripts/Makefile.build',
> adding the missed declaration header file can also fix the error:
>
> getasmexports = \
> { echo "\#include <linux/kernel.h>" ; \
> echo "\#include <linux/string.h>" ; \
> + echo "\#include <linux/uaccess.h>"; \
> echo "\#include <asm/asm-prototypes.h>" ; \
> $(call getexportsymbols,EXPORT_SYMBOL(\1);) ; }
>
So this is simple enough; but the thread you link to also has another
hunk, which makes the whole thing unfortunate.
I'm not entirely sure what this GENDWARFKSYMS nonsense is about, but it
should not clutter the code like that.
next prev parent reply other threads:[~2025-02-13 10:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 3:12 [PATCH] ftrace: x86: Fix a compile error about get_kernel_nofault() Masami Hiramatsu (Google)
2025-02-06 8:12 ` Peter Zijlstra
2025-02-06 11:54 ` Masami Hiramatsu
2025-02-06 12:13 ` Peter Zijlstra
2025-02-06 12:33 ` Peter Zijlstra
2025-02-06 13:25 ` Haiyue Wang
2025-02-07 10:09 ` Peter Zijlstra
2025-02-06 23:59 ` Masami Hiramatsu
2025-02-10 22:30 ` Steven Rostedt
2025-02-11 10:09 ` Peter Zijlstra
2025-02-11 15:50 ` Steven Rostedt
2025-02-12 16:52 ` Sami Tolvanen
2025-02-13 10:08 ` Peter Zijlstra
2025-02-13 10:25 ` Haiyue Wang
2025-02-13 10:40 ` Peter Zijlstra [this message]
2025-02-13 10:50 ` Haiyue Wang
2025-02-13 10:26 ` Peter Zijlstra
2025-02-13 13:35 ` Masami Hiramatsu
2025-02-13 0:03 ` Masami Hiramatsu
2025-02-06 18:19 ` Gabriel de Perthuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213104014.GD28068@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=g2p.code@gmail.com \
--cc=haiyuewa@163.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox