public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Konstantin Taranov <kotaranov@linux.microsoft.com>
Cc: kotaranov@microsoft.com, shirazsaleem@microsoft.com,
	sharmaajay@microsoft.com, longli@microsoft.com, jgg@ziepe.ca,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH next 1/1] RDMA/mana_ib: implement reg_user_mr_dmabuf
Date: Thu, 13 Feb 2025 15:26:20 +0200	[thread overview]
Message-ID: <20250213132620.GL17863@unreal> (raw)
In-Reply-To: <1739180908-2833-1-git-send-email-kotaranov@linux.microsoft.com>

On Mon, Feb 10, 2025 at 01:48:28AM -0800, Konstantin Taranov wrote:
> From: Konstantin Taranov <kotaranov@microsoft.com>
> 
> Add support of dmabuf MRs to mana_ib.
> 
> Signed-off-by: Konstantin Taranov <kotaranov@microsoft.com>
> ---
>  drivers/infiniband/hw/mana/device.c  |  1 +
>  drivers/infiniband/hw/mana/mana_ib.h |  4 ++
>  drivers/infiniband/hw/mana/mr.c      | 77 ++++++++++++++++++++++++++++
>  3 files changed, 82 insertions(+)

<...>

> +	ibdev_dbg(ibdev,
> +		  "dmabuf 0x%llx, iova 0x%llx length 0x%llx access_flags 0x%x",
> +		  start, iova, length, access_flags);

<...>

> +	ibdev_dbg(ibdev,
> +		  "created dma region for user-mr 0x%llx\n",
> +		  dma_region_handle);

Please reduce the amount of debug prints, especially copy-pasted one.

Thanks

      parent reply	other threads:[~2025-02-13 13:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-10  9:48 [PATCH next 1/1] RDMA/mana_ib: implement reg_user_mr_dmabuf Konstantin Taranov
2025-02-12 20:20 ` Long Li
2025-02-13 13:26 ` Leon Romanovsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250213132620.GL17863@unreal \
    --to=leon@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=kotaranov@linux.microsoft.com \
    --cc=kotaranov@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=longli@microsoft.com \
    --cc=sharmaajay@microsoft.com \
    --cc=shirazsaleem@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox