From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Saravana Kannan <saravanak@google.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Danilo Krummrich" <dakr@kernel.org>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Hervé Codina" <herve.codina@bootlin.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: core: fix device leak in __fw_devlink_relax_cycles()
Date: Thu, 13 Feb 2025 15:02:50 +0100 [thread overview]
Message-ID: <20250213150250.4be60b24@booty> (raw)
In-Reply-To: <CAGETcx_WWxeovfDdX+oN8BreknNnQ5CBKNoxB5X9z2VQsOxd7A@mail.gmail.com>
Hi Saravana,
On Thu, 13 Feb 2025 00:11:31 -0800
Saravana Kannan <saravanak@google.com> wrote:
> On Wed, Feb 12, 2025 at 2:31 AM Luca Ceresoli <luca.ceresoli@bootlin.com> wrote:
> >
> > Commit bac3b10b78e5 ("driver core: fw_devlink: Stop trying to optimize
> > cycle detection logic") introduced a new struct device *con_dev and a
> > get_dev_from_fwnode() call to get it, but without adding a corresponding
> > put_device().
>
> Thanks for debugging this and fixing it! Glad to see more people
> fixing fw_devlink code :)
>
> > Link: https://lore.kernel.org/all/20241204124826.2e055091@booty/
> Use the Closes: tag for this link. That tag is used to point to the
> bug report that this patch is fixing.
Good point! Sending v2 with Closes: tag and Cc: stable.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2025-02-13 14:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 10:31 [PATCH] drivers: core: fix device leak in __fw_devlink_relax_cycles() Luca Ceresoli
2025-02-12 10:39 ` Greg Kroah-Hartman
2025-02-13 8:11 ` Saravana Kannan
2025-02-13 14:02 ` Luca Ceresoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213150250.4be60b24@booty \
--to=luca.ceresoli@bootlin.com \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=herve.codina@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=saravanak@google.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox