From: Peter Zijlstra <peterz@infradead.org>
To: Mike Rapoport <rppt@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
"Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>,
Daniel Gomez <da.gomez@samsung.com>,
Petr Pavlu <petr.pavlu@suse.com>,
Sami Tolvanen <samitolvanen@google.com>,
linux-kernel@vger.kernel.org, linux-modules@vger.kernel.org,
x86@kernel.org
Subject: Re: [PATCH] module: don't annotate ROX memory as kmemleak_not_leak()
Date: Fri, 14 Feb 2025 10:19:47 +0100 [thread overview]
Message-ID: <20250214091947.GA21726@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <20250214084531.3299390-1-rppt@kernel.org>
On Fri, Feb 14, 2025 at 10:45:31AM +0200, Mike Rapoport wrote:
> From: "Mike Rapoport (Microsoft)" <rppt@kernel.org>
>
> The ROX memory allocations are part of a larger vmalloc allocation and
> annotating them with kmemleak_not_leak() confuses kmemleak.
>
> Skip kmemleak_not_leak() annotations for the ROX areas.
>
> Fixes: c287c0723329 ("module: switch to execmem API for remapping as RW and restoring ROX")
> Fixes: 64f6a4e10c05 ("x86: re-enable EXECMEM_ROX support")
> Reported-by: "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>
> Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
> ---
>
> Peter, can you take it via tip tree?
> Or you prefer for Luis to pick this up?
Less of a head-ache overall if these things stay together I recon.
So I'll stick it in tip/x86/mm along with the rest of those patches.
Thanks!
next prev parent reply other threads:[~2025-02-14 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 8:45 [PATCH] module: don't annotate ROX memory as kmemleak_not_leak() Mike Rapoport
2025-02-14 9:19 ` Peter Zijlstra [this message]
2025-02-15 10:56 ` [tip: x86/core] " tip-bot2 for Mike Rapoport (Microsoft)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250214091947.GA21726@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=chaitanya.kumar.borah@intel.com \
--cc=da.gomez@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-modules@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=petr.pavlu@suse.com \
--cc=rppt@kernel.org \
--cc=samitolvanen@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox