From: Peter Zijlstra <peterz@infradead.org>
To: Tamir Duberstein <tamird@gmail.com>
Cc: David Gow <davidgow@google.com>, Ingo Molnar <mingo@redhat.com>,
Will Deacon <will@kernel.org>, Boqun Feng <boqun.feng@gmail.com>,
Waiman Long <longman@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Shuah Khan <shuah@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Dan Carpenter <dan.carpenter@linaro.org>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
llvm@lists.linux.dev
Subject: Re: [PATCH v2] ww_mutex: convert self-test to KUnit
Date: Fri, 14 Feb 2025 10:48:56 +0100 [thread overview]
Message-ID: <20250214094856.GD21726@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <CAJ-ks9mzYWSvVD=PCvCBohXg77BdFODq4ePMNstkL+70tkU5RA@mail.gmail.com>
On Thu, Feb 13, 2025 at 10:42:24AM -0500, Tamir Duberstein wrote:
> On Thu, Feb 13, 2025 at 6:59 AM Peter Zijlstra <peterz@infradead.org> wrote:
> >
> > On Thu, Feb 13, 2025 at 06:40:20AM -0500, Tamir Duberstein wrote:
> > > Convert this unit test to a KUnit test. This allows the test to benefit
> > > from the KUnit tooling. Note that care is taken to avoid test-ending
> > > assertions in worker threads, which is unsafe in KUnit (and wasn't done
> > > before this change either).
> >
> > So this was something simple, and now I need to know how to operate this
> > kunit nonsense :-(
> >
> > How is that an improvement?
>
> Hi Peter,
>
> David enumerated some of the benefits of KUnit in another
> thread: https://lore.kernel.org/all/CABVgOS=KZrM2dWyp1HzVS0zh7vquLxmTY2T2Ti53DQADrW+sJg@mail.gmail.com/.
>
> My personal reason for preferring KUnit is that it's much easier to
> run from userspace; the tooling takes care of building, starting the
> VM, running the tests, and producing a human-friendly report.
Wait what -- you have to run a VM just to use Kunit? That's a hard pass.
If I can't simply run it natively on my test box, its a no go. And it
using python also don't help, you shouldn't be needing that to load a
module.
next prev parent reply other threads:[~2025-02-14 9:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-13 11:40 [PATCH v2] ww_mutex: convert self-test to KUnit Tamir Duberstein
2025-02-13 11:59 ` Peter Zijlstra
2025-02-13 15:42 ` Tamir Duberstein
2025-02-14 9:48 ` Peter Zijlstra [this message]
2025-02-14 12:37 ` Tamir Duberstein
2025-02-21 20:35 ` Tamir Duberstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250214094856.GD21726@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=boqun.feng@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=davidgow@google.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=longman@redhat.com \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=shuah@kernel.org \
--cc=tamird@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox