Re: [PATCH v3 07/18] cxl/region: Avoid duplicate call of cxl_find_decoder_early()

Robert Richter
2025-03-06T09:16:58Z

On 14.02.25 16:07:25, Jonathan Cameron wrote:
> On Tue, 11 Feb 2025 10:53:37 +0100
> Robert Richter <rrichter@amd.com> wrote:
>
> > Function cxl_find_decoder_early() is called twice, in
> > alloc_region_ref() and cxl_rr_alloc_decoder(). Move it out there and
>
> out where? I'd make it clear that both these calls are in
> cxl_port_attach_region()
>
> > instead pass the decoder as function argument to both.
> >
> > Signed-off-by: Robert Richter <rrichter@amd.com>
> > Reviewed-by: Gregory Price <gourry@gourry.net>
> > Tested-by: Gregory Price <gourry@gourry.net>
>
> I think this is fine but it's not immediately obvious so a request
> inline for some more details in this description.

I have updated the patch description.

-Robert