Re: [PATCH v3 18/18] cxl/acpi: Unify CFMWS memory log messages with SRAT messages

Dave Jiang
2025-02-20T17:46:07Z

On 2/11/25 2:53 AM, Robert Richter wrote:
> CFMWS entries have a similar importance as SRAT table entries to
> describe memory regions. For CXL error analysis and memory debugging
> information of both is needed. Unify output of both messages to
> improve logging. Change the style of CFMWS message according to SRAT
> output. Also, turn messages into a dev_info() same as for SRAT.
>
> SRAT pr_info() for reference:
>
> drivers/acpi/numa/srat.c:
> pr_info("SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx]%s%s\n",
>
> Signed-off-by: Robert Richter <rrichter@amd.com>
> Reviewed-by: Gregory Price <gourry@gourry.net>
> Tested-by: Gregory Price <gourry@gourry.net>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/cxl/acpi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/acpi.c b/drivers/cxl/acpi.c
> index 3e75e612cbc4..93c73b163c28 100644
> --- a/drivers/cxl/acpi.c
> +++ b/drivers/cxl/acpi.c
> @@ -447,7 +447,7 @@ static int cxl_parse_cfmws(union acpi_subtable_headers *header, void *arg,
> cfmws->base_hpa,
> cfmws->base_hpa + cfmws->window_size - 1, rc);
> else
> - dev_dbg(dev, "decode range: node: %d range [%#llx - %#llx]\n",
> + dev_info(dev, "ACPI: CFMWS: Node %u [mem %#010Lx-%#010Lx]\n",
> phys_to_target_node(cfmws->base_hpa), cfmws->base_hpa,
> cfmws->base_hpa + cfmws->window_size - 1);
>