From: Jeongjun Park <aha310510@gmail.com>
To: akpm@linux-foundation.org
Cc: Liam.Howlett@Oracle.com, brauner@kernel.org,
lorenzo.stoakes@oracle.com, willy@infradead.org,
davidlohr.bueso@hp.com, linux-kernel@vger.kernel.org,
Jeongjun Park <aha310510@gmail.com>
Subject: [PATCH] ipc: fix to protect IPCS lookups using RCU instead of semaphore
Date: Sat, 15 Feb 2025 03:01:57 +0900 [thread overview]
Message-ID: <20250214180157.10288-1-aha310510@gmail.com> (raw)
In shm_destroy_orphaned(), we are not performing updates to the IPCS and are
only calling idr_for_each(), which can be protected by the RCU read-critical
section.
And if idr_for_each() is not protected by the RCU read-critical section,
then when radix_tree_node_free() is called to free the struct radix_tree_node
through call_rcu(), the node will be freed immediately, and when reading the
next node in radix_tree_for_each_slot(), the memory that has already been
freed may be read.
Therefore, I think it is appropriate to use RCU instead of semaphore to
protect it.
Fixes: d9a605e40b13 ("ipc: rename ids->rw_mutex")
Signed-off-by: Jeongjun Park <aha310510@gmail.com>
---
ipc/shm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/ipc/shm.c b/ipc/shm.c
index 99564c870084..8fd87c4e5dc8 100644
--- a/ipc/shm.c
+++ b/ipc/shm.c
@@ -430,10 +430,10 @@ static int shm_try_destroy_orphaned(int id, void *p, void *data)
void shm_destroy_orphaned(struct ipc_namespace *ns)
{
- down_write(&shm_ids(ns).rwsem);
+ rcu_read_lock();
if (shm_ids(ns).in_use)
idr_for_each(&shm_ids(ns).ipcs_idr, &shm_try_destroy_orphaned, ns);
- up_write(&shm_ids(ns).rwsem);
+ rcu_read_unlock();
}
/* Locking assumes this will only be called with task == current */
--
next reply other threads:[~2025-02-14 18:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 18:01 Jeongjun Park [this message]
2025-02-14 18:58 ` [PATCH] ipc: fix to protect IPCS lookups using RCU instead of semaphore Matthew Wilcox
2025-02-14 23:21 ` Andrew Morton
2025-02-15 5:00 ` Jeongjun Park
2025-02-15 17:39 ` Matthew Wilcox
2025-02-19 10:07 ` Jeongjun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250214180157.10288-1-aha310510@gmail.com \
--to=aha310510@gmail.com \
--cc=Liam.Howlett@Oracle.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=davidlohr.bueso@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox