Re: [PATCH v2 15/17] cpufreq/amd-pstate: Drop debug statements for policy setting

Gautham R. Shenoy
2025-02-17T14:31:22Z

On Fri, Feb 14, 2025 at 06:52:42PM -0600, Mario Limonciello wrote:
> From: Mario Limonciello <mario.limonciello@amd.com>
>
> There are trace events that exist now for all amd-pstate modes that
> will output information right before programming to the hardware.
>
> This makes the existing debug statements unnecessary remaining
> overhead. Drop them.

Ack.

Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>

>
> Reviewed-by: Dhananjay Ugwekar <dhananjay.ugwekar@amd.com>
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/cpufreq/amd-pstate.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index fd2b559f47c5c..b39bed12b360f 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -667,7 +667,6 @@ static int amd_pstate_verify(struct cpufreq_policy_data *policy_data)
> }
>
> cpufreq_verify_within_cpu_limits(policy_data);
> - pr_debug("policy_max =%d, policy_min=%d\n", policy_data->max, policy_data->min);
>
> return 0;
> }
> @@ -1632,9 +1631,6 @@ static int amd_pstate_epp_set_policy(struct cpufreq_policy *policy)
> if (!policy->cpuinfo.max_freq)
> return -ENODEV;
>
> - pr_debug("set_policy: cpuinfo.max %u policy->max %u\n",
> - policy->cpuinfo.max_freq, policy->max);
> -
> cpudata->policy = policy->policy;
>
> ret = amd_pstate_epp_update_limit(policy);
> --
> 2.43.0
>

--
Thanks and Regards
gautham.