Re: [PATCH v2 11/17] cpufreq/amd-pstate: Replace all AMD_CPPC_* macros with masks

kernel test robot
2025-02-17T17:13:06Z

Hi Mario,

kernel test robot noticed the following build errors:

[auto build test ERROR on amd-pstate/linux-next]
[also build test ERROR on amd-pstate/bleeding-edge]
[cannot apply to rafael-pm/linux-next rafael-pm/bleeding-edge tip/x86/core linus/master v6.14-rc3 next-20250217]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/cpufreq-amd-pstate-Show-a-warning-when-a-CPU-fails-to-setup/20250215-085903
base: https://git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git linux-next
patch link: https://lore.kernel.org/r/20250215005244.1212285-12-superm1%40kernel.org
patch subject: [PATCH v2 11/17] cpufreq/amd-pstate: Replace all AMD_CPPC_* macros with masks
config: i386-randconfig-063-20250216 (https://download.01.org/0day-ci/archive/20250218/202502180139.g2a2yoPe-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250218/202502180139.g2a2yoPe-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502180139.g2a2yoPe-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/cpufreq/amd-pstate-ut.c:145:19: error: call to undeclared function 'FIELD_GET'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
145 | highest_perf = FIELD_GET(AMD_CPPC_HIGHEST_PERF_MASK, cap1);
| ^
1 error generated.

vim +/FIELD_GET +145 drivers/cpufreq/amd-pstate-ut.c

105
106 /*
107 * check if performance values are reasonable.
108 * highest_perf >= nominal_perf > lowest_nonlinear_perf > lowest_perf > 0
109 */
110 static int amd_pstate_ut_check_perf(u32 index)
111 {
112 int cpu = 0, ret = 0;
113 u32 highest_perf = 0, nominal_perf = 0, lowest_nonlinear_perf = 0, lowest_perf = 0;
114 u64 cap1 = 0;
115 struct cppc_perf_caps cppc_perf;
116 struct amd_cpudata *cpudata = NULL;
117 union perf_cached cur_perf;
118
119 for_each_possible_cpu(cpu) {
120 struct cpufreq_policy *policy __free(put_cpufreq_policy) = NULL;
121
122 policy = cpufreq_cpu_get(cpu);
123 if (!policy)
124 continue;
125 cpudata = policy->driver_data;
126
127 if (get_shared_mem()) {
128 ret = cppc_get_perf_caps(cpu, &cppc_perf);
129 if (ret) {
130 pr_err("%s cppc_get_perf_caps ret=%d error!\n", __func__, ret);
131 return ret;
132 }
133
134 highest_perf = cppc_perf.highest_perf;
135 nominal_perf = cppc_perf.nominal_perf;
136 lowest_nonlinear_perf = cppc_perf.lowest_nonlinear_perf;
137 lowest_perf = cppc_perf.lowest_perf;
138 } else {
139 ret = rdmsrl_safe_on_cpu(cpu, MSR_AMD_CPPC_CAP1, &cap1);
140 if (ret) {
141 pr_err("%s read CPPC_CAP1 ret=%d error!\n", __func__, ret);
142 return ret;
143 }
144
> 145 highest_perf = FIELD_GET(AMD_CPPC_HIGHEST_PERF_MASK, cap1);
146 nominal_perf = FIELD_GET(AMD_CPPC_NOMINAL_PERF_MASK, cap1);
147 lowest_nonlinear_perf = FIELD_GET(AMD_CPPC_LOWNONLIN_PERF_MASK, cap1);
148 lowest_perf = FIELD_GET(AMD_CPPC_LOWEST_PERF_MASK, cap1);
149 }
150
151 cur_perf = READ_ONCE(cpudata->perf);
152 if (highest_perf != cur_perf.highest_perf && !cpudata->hw_prefcore) {
153 pr_err("%s cpu%d highest=%d %d highest perf doesn't match\n",
154 __func__, cpu, highest_perf, cpudata->perf.highest_perf);
155 return -EINVAL;
156 }
157 if (nominal_perf != cur_perf.nominal_perf ||
158 (lowest_nonlinear_perf != cur_perf.lowest_nonlinear_perf) ||
159 (lowest_perf != cur_perf.lowest_perf)) {
160 pr_err("%s cpu%d nominal=%d %d lowest_nonlinear=%d %d lowest=%d %d, they should be equal!\n",
161 __func__, cpu, nominal_perf, cpudata->perf.nominal_perf,
162 lowest_nonlinear_perf, cpudata->perf.lowest_nonlinear_perf,
163 lowest_perf, cpudata->perf.lowest_perf);
164 return -EINVAL;
165 }
166
167 if (!((highest_perf >= nominal_perf) &&
168 (nominal_perf > lowest_nonlinear_perf) &&
169 (lowest_nonlinear_perf >= lowest_perf) &&
170 (lowest_perf > 0))) {
171 pr_err("%s cpu%d highest=%d >= nominal=%d > lowest_nonlinear=%d > lowest=%d > 0, the formula is incorrect!\n",
172 __func__, cpu, highest_perf, nominal_perf,
173 lowest_nonlinear_perf, lowest_perf);
174 return -EINVAL;
175 }
176 }
177
178 return 0;
179 }
180

--
0-DAY CI Kernel Test Service