From: Guilherme Giacomo Simoes <trintaeoitogc@gmail.com>
To: benno.lossin@proton.me
Cc: a.hindborg@kernel.org, alex.gaynor@gmail.com,
aliceryhl@google.com, apw@canonical.com, arnd@arndb.de,
aswinunni01@gmail.com, axboe@kernel.dk, bhelgaas@google.com,
bjorn3_gh@protonmail.com, boqun.feng@gmail.com, dakr@kernel.org,
dwaipayanray1@gmail.com, ethan.twardy@gmail.com,
fujita.tomonori@gmail.com, gary@garyguo.net,
gregkh@linuxfoundation.org, joe@perches.com,
linux-kernel@vger.kernel.org, lukas.bulwahn@gmail.com,
miguel.ojeda.sandonis@gmail.com, ojeda@kernel.org,
pbonzini@redhat.com, rust-for-linux@vger.kernel.org,
tmgross@umich.edu, trintaeoitogc@gmail.com,
walmeida@microsoft.com
Subject: Re: [PATCH V2 1/2] rust: module: change author to be a array
Date: Sat, 15 Feb 2025 10:52:29 -0300 [thread overview]
Message-ID: <20250215135229.300420-1-trintaeoitogc@gmail.com> (raw)
In-Reply-To: <93eaeb37-9913-49cb-be6d-367696a81baf@proton.me>
Benno Lossin <benno.lossin@proton.me> wrote:
> This commit message looks a bit clunky to me, though I am not a native
> speaker. My suggestion would be:
>
> Change the type of the `author` field in the `module!` macro from string
> to string array. This allows multiple authors for a single module as is
> already possible in C.
> Additionally, rename the field to `authors` to better reflect this
> change.
>
> Feel free to change/adapt anything.
Thanks for your suggestions, in the truth my english is not so good.
> As already mentioned above, I think it makes sense to also rename the
> field to `authors`.
When I maked this change, I thinked in change the field name from author to
authors, but I don't doing this because anothers fields that is a array in
module! macro (firmware and alias) are in singular too.
> You should also change the documentation in this file, there the field
> `author` is listed as "string literal of the author of the kernel
> module.", so it also needs to be updated.
Yes, you is right... I haven't seen this chunk of text
Thanks,
Guilherme
next prev parent reply other threads:[~2025-02-15 13:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 18:45 [PATCH V2 0/2] author field in module! macro should be a array Guilherme Giacomo Simoes
2025-02-14 18:45 ` [PATCH V2 1/2] rust: module: change author to " Guilherme Giacomo Simoes
2025-02-14 20:19 ` Charalampos Mitrodimas
2025-02-15 1:11 ` Guilherme Giacomo Simoes
2025-02-15 1:39 ` Benno Lossin
2025-02-15 13:52 ` Guilherme Giacomo Simoes [this message]
2025-02-15 14:34 ` Benno Lossin
2025-02-16 12:35 ` kernel test robot
2025-02-14 18:45 ` [PATCH V2 2/2] checkpatch: throw error in malformed arrays Guilherme Giacomo Simoes
2025-02-15 5:24 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250215135229.300420-1-trintaeoitogc@gmail.com \
--to=trintaeoitogc@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=apw@canonical.com \
--cc=arnd@arndb.de \
--cc=aswinunni01@gmail.com \
--cc=axboe@kernel.dk \
--cc=benno.lossin@proton.me \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=dwaipayanray1@gmail.com \
--cc=ethan.twardy@gmail.com \
--cc=fujita.tomonori@gmail.com \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=pbonzini@redhat.com \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
--cc=walmeida@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox