From: Sudeep Holla <sudeep.holla@arm.com>
To: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Sudeep Holla <sudeep.holla@arm.com>,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH v3 13/19] firmware: arm_ffa: Remove unnecessary declaration of ffa_partitions_cleanup()
Date: Mon, 17 Feb 2025 15:38:54 +0000 [thread overview]
Message-ID: <20250217-ffa_updates-v3-13-bd1d9de615e7@arm.com> (raw)
In-Reply-To: <20250217-ffa_updates-v3-0-bd1d9de615e7@arm.com>
In order to keep the uniformity, just move the ffa_partitions_cleanup()
before it's first usage and drop the unnecessary forward declaration.
No functional change.
Tested-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/firmware/arm_ffa/driver.c | 33 ++++++++++++++++-----------------
1 file changed, 16 insertions(+), 17 deletions(-)
diff --git a/drivers/firmware/arm_ffa/driver.c b/drivers/firmware/arm_ffa/driver.c
index ad2f6b410e4431bb133fa0f05dd3eec802f5ee07..43e033edd6c7cd16322c204e882a84cfe45abbba 100644
--- a/drivers/firmware/arm_ffa/driver.c
+++ b/drivers/firmware/arm_ffa/driver.c
@@ -114,7 +114,6 @@ struct ffa_drv_info {
};
static struct ffa_drv_info *drv_info;
-static void ffa_partitions_cleanup(void);
/*
* The driver must be able to support all the versions from the earliest
@@ -1452,6 +1451,22 @@ static int ffa_xa_add_partition_info(int vm_id)
return ret;
}
+static void ffa_partitions_cleanup(void)
+{
+ struct ffa_dev_part_info *info;
+ unsigned long idx;
+
+ /* Clean up/free all registered devices */
+ ffa_devices_unregister();
+
+ xa_for_each(&drv_info->partition_info, idx, info) {
+ xa_erase(&drv_info->partition_info, idx);
+ kfree(info);
+ }
+
+ xa_destroy(&drv_info->partition_info);
+}
+
static int ffa_setup_partitions(void)
{
int count, idx, ret;
@@ -1509,22 +1524,6 @@ static int ffa_setup_partitions(void)
return ret;
}
-static void ffa_partitions_cleanup(void)
-{
- struct ffa_dev_part_info *info;
- unsigned long idx;
-
- /* Clean up/free all registered devices */
- ffa_devices_unregister();
-
- xa_for_each(&drv_info->partition_info, idx, info) {
- xa_erase(&drv_info->partition_info, idx);
- kfree(info);
- }
-
- xa_destroy(&drv_info->partition_info);
-}
-
/* FFA FEATURE IDs */
#define FFA_FEAT_NOTIFICATION_PENDING_INT (1)
#define FFA_FEAT_SCHEDULE_RECEIVER_INT (2)
--
2.34.1
next prev parent reply other threads:[~2025-02-17 15:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 15:38 [PATCH v3 00/19] firmware: arm_ffa: Framework notification support + other updates and fixes Sudeep Holla
2025-02-17 15:38 ` [PATCH v3 01/19] firmware: arm_ffa: Replace SCMI by FF-A in the macro Sudeep Holla
2025-02-17 15:38 ` [PATCH v3 02/19] firmware: arm_ffa: Replace UUID buffer to standard UUID format Sudeep Holla
2025-02-17 15:38 ` [PATCH v3 03/19] firmware: arm_ffa: Align sync_send_receive{,2} function prototypes Sudeep Holla
2025-02-17 15:38 ` [PATCH v3 04/19] firmware: arm_ffa: Fix big-endian support in __ffa_partition_info_get() Sudeep Holla
2025-02-17 15:38 ` [PATCH v3 05/19] firmware: arm_ffa: Fix big-endian support in __ffa_partition_info_regs_get() Sudeep Holla
2025-02-17 15:38 ` [PATCH v3 06/19] firmware: arm_ffa: Refactor addition of partition information into XArray Sudeep Holla
2025-02-17 15:38 ` [PATCH v3 07/19] firmware: arm_ffa: Handle the presence of host partition in the partition info Sudeep Holla
2025-02-17 15:38 ` [PATCH v3 08/19] firmware: arm_ffa: Unregister the FF-A devices when cleaning up the partitions Sudeep Holla
2025-02-17 15:38 ` [PATCH v3 09/19] firmware: arm_ffa: Helper to check if a partition can receive REQUEST2 messages Sudeep Holla
2025-02-17 15:38 ` [PATCH v3 10/19] firmware: arm_ffa: Add support for passing UUID in FFA_MSG_SEND2 Sudeep Holla
2025-02-17 15:38 ` [PATCH v3 11/19] firmware: arm_ffa: Upgrade FF-A version to v1.2 in the driver Sudeep Holla
2025-02-17 15:38 ` [PATCH v3 12/19] firmware: arm_ffa: Reject higher major version as incompatible Sudeep Holla
2025-02-17 15:38 ` Sudeep Holla [this message]
2025-02-17 15:38 ` [PATCH v3 14/19] firmware: arm_ffa: Refactoring to prepare for framework notification support Sudeep Holla
2025-02-17 15:38 ` [PATCH v3 15/19] firmware: arm_ffa: Stash ffa_device instead of notify_type in notifier_cb_info Sudeep Holla
2025-02-17 15:38 ` [PATCH v3 16/19] firmware: arm_ffa: Add support for {un,}registration of framework notifications Sudeep Holla
2025-02-17 15:38 ` [PATCH v3 17/19] firmware: arm_ffa: Add support for handling " Sudeep Holla
2025-02-17 15:38 ` [PATCH v3 18/19] firmware: arm_ffa: Allow multiple UUIDs per partition to register SRI callback Sudeep Holla
2025-02-17 15:39 ` [PATCH v3 19/19] firmware: arm_ffa: Handle ffa_notification_get correctly at virtual FF-A instance Sudeep Holla
2025-02-21 11:41 ` [PATCH v3 00/19] firmware: arm_ffa: Framework notification support + other updates and fixes Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250217-ffa_updates-v3-13-bd1d9de615e7@arm.com \
--to=sudeep.holla@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox