Re: [PATCH] binder: remove unneeded inclusion from binder_internal.h

Todd Kjos
2025-02-24T23:27:10Z

On Mon, Feb 17, 2025 at 3:28 AM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> binder_internal.h is included only in the following two C files:
>
> $ git grep binder_internal.h
> drivers/android/binder.c:#include "binder_internal.h"
> drivers/android/binderfs.c:#include "binder_internal.h"
>
> Neither of these files use the EXPORT_SYMBOL macro, so including
> <linux/export.h> is unnecessary.
>
> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

Acked-by: Todd Kjos <tkjos@google.com>

> ---
>
> drivers/android/binder_internal.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/android/binder_internal.h b/drivers/android/binder_internal.h
> index e4eb8357989c..6a66c9769c6c 100644
> --- a/drivers/android/binder_internal.h
> +++ b/drivers/android/binder_internal.h
> @@ -3,7 +3,6 @@
> #ifndef _LINUX_BINDER_INTERNAL_H
> #define _LINUX_BINDER_INTERNAL_H
>
> -#include <linux/export.h>
> #include <linux/fs.h>
> #include <linux/list.h>
> #include <linux/miscdevice.h>
> --
> 2.43.0
>