From: Leo Yan <leo.yan@arm.com>
To: James Clark <james.clark@linaro.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ian Rogers <irogers@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
John Garry <john.g.garry@oracle.com>,
Will Deacon <will@kernel.org>, Mike Leach <mike.leach@linaro.org>,
Graham Woodward <graham.woodward@arm.com>,
Paschalis.Mpeis@arm.com, linux-perf-users@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 08/11] perf arm-spe: Fill branch operations and events to record
Date: Mon, 17 Feb 2025 20:04:09 +0000 [thread overview]
Message-ID: <20250217200409.GC8144@e132581.arm.com> (raw)
In-Reply-To: <a5d99e7f-1d8d-41f1-976d-7d67a0d5decb@linaro.org>
On Mon, Feb 17, 2025 at 04:20:57PM +0000, James Clark wrote:
[...]
> > diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> > index ba807071d3c1..52bd0a4ea96d 100644
> > --- a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> > +++ b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> > @@ -207,6 +207,18 @@ static int arm_spe_read_record(struct arm_spe_decoder *decoder)
> > break;
> > case SPE_OP_PKT_HDR_CLASS_BR_ERET:
> > decoder->record.op |= ARM_SPE_OP_BRANCH_ERET;
> > + if (payload & SPE_OP_PKT_COND)
> > + decoder->record.op |= ARM_SPE_OP_BR_COND;
>
> I think this results in memory events being synthesised for these
> samples because of a bug in arm_spe__synth_data_source().
> ARM_SPE_OP_BR_COND overlaps with bits from other packet types like
> ARM_SPE_OP_LD:
>
> if (record->op & ARM_SPE_OP_LD)
> data_src.mem_op = PERF_MEM_OP_LOAD;
>
> arm_spe__synth_data_source() needs to only interpret that as a data
> source packet if ARM_SPE_OP_LDST is set. This was reported by Mike
> Williams but you have the privilege of hitting it for real first.
Good catching. I have added a new patch 06 to fix the bug in the
v3 series. Thanks for hooking up the info.
Leo
next prev parent reply other threads:[~2025-02-17 20:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 11:19 [PATCH v2 00/11] perf script: Refactor branch flags for Arm SPE Leo Yan
2025-02-14 11:19 ` [PATCH v2 01/11] perf script: Make printing flags reliable Leo Yan
2025-02-14 11:19 ` [PATCH v2 02/11] perf script: Refactor sample_flags_to_name() function Leo Yan
2025-02-14 11:19 ` [PATCH v2 03/11] perf script: Separate events from branch types Leo Yan
2025-02-14 11:19 ` [PATCH v2 04/11] perf script: Add not taken event for branches Leo Yan
2025-02-14 11:19 ` [PATCH v2 05/11] perf script: Add not taken event for branch stack Leo Yan
2025-02-14 11:19 ` [PATCH v2 06/11] perf arm-spe: Extend branch operations Leo Yan
2025-02-14 11:19 ` [PATCH v2 07/11] perf arm-spe: Decode transactional event Leo Yan
2025-02-14 11:19 ` [PATCH v2 08/11] perf arm-spe: Fill branch operations and events to record Leo Yan
2025-02-17 16:20 ` James Clark
2025-02-17 20:04 ` Leo Yan [this message]
2025-02-14 11:19 ` [PATCH v2 09/11] perf arm-spe: Set sample flags with supplement info Leo Yan
2025-02-14 11:19 ` [PATCH v2 10/11] perf arm-spe: Add branch stack Leo Yan
2025-02-14 11:19 ` [PATCH v2 11/11] perf arm-spe: Support previous branch target (PBT) address Leo Yan
2025-02-17 16:28 ` [PATCH v2 00/11] perf script: Refactor branch flags for Arm SPE James Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250217200409.GC8144@e132581.arm.com \
--to=leo.yan@arm.com \
--cc=Paschalis.Mpeis@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=graham.woodward@arm.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox