From: Greg KH <gregkh@linuxfoundation.org>
To: Ravi Kumar kairi <kumarkairiravi@gmail.com>
Cc: dpenkler@gmail.com, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, kuba@kernel.org,
dan.carpenter@linaro.org, rmk+kernel@armlinux.org.uk
Subject: Re: [PATCH v3 4/4] [PATCH V2 4/4] staging:gpib:agilent_82350b: Fix Indent issue with block
Date: Mon, 17 Feb 2025 11:39:06 +0100 [thread overview]
Message-ID: <2025021742-shoplift-arrogant-937f@gregkh> (raw)
In-Reply-To: <20250217103046.54294-5-kumarkairiravi@gmail.com>
On Mon, Feb 17, 2025 at 04:00:38PM +0530, Ravi Kumar kairi wrote:
> From: Ravi Kumar Kairi <kumarkairiravi@gmail.com>
>
> There was a empty line, which was causing the checkpatch script to think
> it's a single line statment, after removing the empty line it's no
> longer asking to check that line.
>
> Signed-off-by: Ravi Kumar Kairi <kumarkairiravi@gmail.com>
> ---
> drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
> index b6871eb3c8..1d644d000a 100644
> --- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
> +++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
> @@ -228,7 +228,6 @@ static int agilent_82350b_accel_write(gpib_board_t *board, uint8_t *buffer, size
> return retval;
>
> if (send_eoi) {
> -
> retval = agilent_82350b_write(board, buffer + fifotransferlength, 1, send_eoi,
> &num_bytes);
> *bytes_written += num_bytes;
The subject line is really odd as this change has nothing to do with
indentation :(
thanks,
greg k-h
next prev parent reply other threads:[~2025-02-17 10:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 10:30 [PATCH v3 0/4] staging:gpib:agilent_82350b: Code cleanup, spelling fixes Ravi Kumar kairi
2025-02-17 10:30 ` [PATCH v3 1/4] [PATCH V2 1/4] staging:gpib:agilent_82350b: Fixed spelling error Ravi Kumar kairi
2025-02-17 10:30 ` [PATCH v3 2/4] [PATCH V2 2/4] staging:gpib:agilent_82350b: Removed commented out code Ravi Kumar kairi
2025-02-17 13:31 ` Dan Carpenter
[not found] ` <CAEEw=4mN+Y8G6a92baCH6kANcpmTFDzn_LSS3XRfXAFdPZxo8A@mail.gmail.com>
2025-02-17 14:19 ` Dan Carpenter
2025-02-17 10:30 ` [PATCH v3 3/4] [PATCH V2 3/4] staging:gpib:agilent_82350b:Removed blank line Ravi Kumar kairi
2025-02-17 10:38 ` Greg KH
2025-02-17 10:30 ` [PATCH v3 4/4] [PATCH V2 4/4] staging:gpib:agilent_82350b: Fix Indent issue with block Ravi Kumar kairi
2025-02-17 10:39 ` Greg KH [this message]
2025-02-17 11:01 ` Ravi Kumar Kairi
2025-02-17 10:37 ` [PATCH v3 0/4] staging:gpib:agilent_82350b: Code cleanup, spelling fixes Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025021742-shoplift-arrogant-937f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=dan.carpenter@linaro.org \
--cc=dpenkler@gmail.com \
--cc=kuba@kernel.org \
--cc=kumarkairiravi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox