Re: [PATCH] drm/nouveau/pmu: Fix gp10b firmware guard

[Zhi Wang <zhiw@nvidia.com>]

On Mon, 17 Feb 2025 17:46:41 -0600
Aaron Kling <webgeek1234@gmail.com> wrote:

> On Mon, Feb 17, 2025 at 5:43 PM Aaron Kling via B4 Relay
> <devnull+webgeek1234.gmail.com@kernel.org> wrote:
> >
> > From: Aaron Kling <webgeek1234@gmail.com>
> >
> > Fixes: 989863d7cbe5 ("drm/nouveau/pmu: select implementation based on available firmware")
> > Signed-off-by: Aaron Kling <webgeek1234@gmail.com>
> > ---
> >  drivers/gpu/drm/nouveau/nvkm/subdev/pmu/gp10b.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/gp10b.c b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/gp10b.c
> > index a6f410ba60bc94ec9d52fc78868acddfc6770e19..d393bc540f8628812990dffe4c2f7e9014be07c5 100644
> > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/gp10b.c
> > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/pmu/gp10b.c
> > @@ -75,7 +75,7 @@ gp10b_pmu_acr = {
> >         .bootstrap_multiple_falcons = gp10b_pmu_acr_bootstrap_multiple_falcons,
> >  };
> >
> > -#if IS_ENABLED(CONFIG_ARCH_TEGRA_210_SOC)
> > +#if IS_ENABLED(CONFIG_ARCH_TEGRA_186_SOC)
> >  MODULE_FIRMWARE("nvidia/gp10b/pmu/desc.bin");
> >  MODULE_FIRMWARE("nvidia/gp10b/pmu/image.bin");
> >  MODULE_FIRMWARE("nvidia/gp10b/pmu/sig.bin");
> >
> > ---
> > base-commit: 2408a807bfc3f738850ef5ad5e3fd59d66168996
> > change-id: 20250217-nouveau-gm10b-guard-a438402b5022
> >
> > Best regards,
> > --
> > Aaron Kling <webgeek1234@gmail.com>
> >
> >
> 
> Apologies to the maintainers for the multiple resends. For some reason
> the lists weren't accepting my submissions. Looks like it went through
> with b4, so hopefully I won't have more trouble in the future.
> 

It seems like this version doesn't have a comment body. Might need to
double check the b4 setup.

> Sincerely,
> Aaron Kling
>