From: "José Expósito" <jose.exposito89@gmail.com>
To: louis.chauvet@bootlin.com
Cc: hamohammed.sa@gmail.com, simona@ffwll.ch, melissa.srw@gmail.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
"José Expósito" <jose.exposito89@gmail.com>
Subject: [PATCH 06/16] drm/vkms: Allow to configure CRTC writeback support via configfs
Date: Tue, 18 Feb 2025 18:07:58 +0100 [thread overview]
Message-ID: <20250218170808.9507-7-jose.exposito89@gmail.com> (raw)
In-Reply-To: <20250218170808.9507-1-jose.exposito89@gmail.com>
When a CRTC is created, add a `writeback` file to allow to enable or
disable writeback connector support
Co-developed-by: Louis Chauvet <louis.chauvet@bootlin.com>
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
Signed-off-by: José Expósito <jose.exposito89@gmail.com>
---
Documentation/gpu/vkms.rst | 4 +++
drivers/gpu/drm/vkms/vkms_configfs.c | 47 ++++++++++++++++++++++++++++
2 files changed, 51 insertions(+)
diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu/vkms.rst
index da5157adfd79..4e87d8a81844 100644
--- a/Documentation/gpu/vkms.rst
+++ b/Documentation/gpu/vkms.rst
@@ -93,6 +93,10 @@ Continue by creating one or more CRTCs::
sudo mkdir /config/vkms/my-vkms/crtcs/crtc0
+CRTCs have 1 configurable attribute:
+
+- writeback: Enable or disable writeback connector support
+
Once you are done configuring the VKMS instance, enable it::
echo "1" | sudo tee /config/vkms/my-vkms/enabled
diff --git a/drivers/gpu/drm/vkms/vkms_configfs.c b/drivers/gpu/drm/vkms/vkms_configfs.c
index 52205a8a9cb4..88037a57a138 100644
--- a/drivers/gpu/drm/vkms/vkms_configfs.c
+++ b/drivers/gpu/drm/vkms/vkms_configfs.c
@@ -73,6 +73,52 @@ struct vkms_configfs_crtc {
#define crtc_item_to_vkms_configfs_crtc(item) \
container_of(to_config_group((item)), struct vkms_configfs_crtc, group)
+static ssize_t crtc_writeback_show(struct config_item *item, char *page)
+{
+ struct vkms_configfs_crtc *crtc;
+ bool writeback;
+
+ crtc = crtc_item_to_vkms_configfs_crtc(item);
+
+ mutex_lock(&crtc->dev->lock);
+ writeback = vkms_config_crtc_get_writeback(crtc->config);
+ mutex_unlock(&crtc->dev->lock);
+
+ return sprintf(page, "%d\n", writeback);
+}
+
+static ssize_t crtc_writeback_store(struct config_item *item, const char *page,
+ size_t count)
+{
+ struct vkms_configfs_crtc *crtc;
+ bool writeback;
+
+ crtc = crtc_item_to_vkms_configfs_crtc(item);
+
+ if (kstrtobool(page, &writeback))
+ return -EINVAL;
+
+ mutex_lock(&crtc->dev->lock);
+
+ if (crtc->dev->enabled) {
+ mutex_unlock(&crtc->dev->lock);
+ return -EPERM;
+ }
+
+ vkms_config_crtc_set_writeback(crtc->config, writeback);
+
+ mutex_unlock(&crtc->dev->lock);
+
+ return (ssize_t)count;
+}
+
+CONFIGFS_ATTR(crtc_, writeback);
+
+static struct configfs_attribute *crtc_item_attrs[] = {
+ &crtc_attr_writeback,
+ NULL,
+};
+
static void crtc_release(struct config_item *item)
{
struct vkms_configfs_crtc *crtc;
@@ -92,6 +138,7 @@ static struct configfs_item_operations crtc_item_operations = {
};
static const struct config_item_type crtc_item_type = {
+ .ct_attrs = crtc_item_attrs,
.ct_item_ops = &crtc_item_operations,
.ct_owner = THIS_MODULE,
};
--
2.48.1
next prev parent reply other threads:[~2025-02-18 17:08 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 17:07 [PATCH 00/16] drm/vkms: Add configfs support José Expósito
2025-02-18 17:07 ` [PATCH 01/16] drm/vkms: Expose device creation and destruction José Expósito
2025-02-25 11:02 ` Louis Chauvet
2025-02-18 17:07 ` [PATCH 02/16] drm/vkms: Add and remove VKMS instances via configfs José Expósito
2025-02-25 11:02 ` Louis Chauvet
2025-02-18 17:07 ` [PATCH 03/16] drm/vkms: Allow to configure multiple planes " José Expósito
2025-02-25 11:01 ` Louis Chauvet
2025-02-25 11:02 ` Louis Chauvet
2025-02-18 17:07 ` [PATCH 04/16] drm/vkms: Allow to configure the plane type " José Expósito
2025-02-25 11:02 ` Louis Chauvet
2025-02-18 17:07 ` [PATCH 05/16] drm/vkms: Allow to configure multiple CRTCs " José Expósito
2025-02-25 11:02 ` Louis Chauvet
2025-02-18 17:07 ` José Expósito [this message]
2025-02-25 11:02 ` [PATCH 06/16] drm/vkms: Allow to configure CRTC writeback support " Louis Chauvet
2025-02-18 17:07 ` [PATCH 07/16] drm/vkms: Allow to attach planes and CRTCs " José Expósito
2025-02-18 17:08 ` [PATCH 08/16] drm/vkms: Allow to configure multiple encoders " José Expósito
2025-02-25 11:02 ` Louis Chauvet
2025-02-18 17:08 ` [PATCH 09/16] drm/vkms: Allow to attach encoders and CRTCs " José Expósito
2025-02-18 17:08 ` [PATCH 10/16] drm/vkms: Allow to configure multiple connectors " José Expósito
2025-02-25 11:02 ` Louis Chauvet
2025-02-18 17:08 ` [PATCH 11/16] drm/vkms: Allow to attach connectors and encoders " José Expósito
2025-02-18 17:08 ` [PATCH 12/16] drm/vkms: Allow to configure connector status José Expósito
2025-02-18 17:08 ` [PATCH 13/16] drm/vkms: Allow to update the " José Expósito
2025-02-18 17:08 ` [PATCH 14/16] drm/vkms: Allow to configure connector status via configfs José Expósito
2025-02-18 17:08 ` [PATCH 15/16] drm/vkms: Allow to configure the default device creation José Expósito
2025-02-25 11:02 ` Louis Chauvet
2025-02-18 17:08 ` [PATCH 16/16] drm/vkms: Remove completed task from the TODO list José Expósito
2025-02-25 11:01 ` Louis Chauvet
2025-02-25 11:01 ` [PATCH 00/16] drm/vkms: Add configfs support Louis Chauvet
2025-02-25 17:56 ` José Expósito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250218170808.9507-7-jose.exposito89@gmail.com \
--to=jose.exposito89@gmail.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=louis.chauvet@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=melissa.srw@gmail.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox