From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <purvayeshi550@gmail.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <horms@kernel.org>,
<kuba@kernel.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>,
<skhan@linuxfoundation.org>,
Kuniyuki Iwashima <kuniyu@amazon.com>
Subject: Re: [PATCH net-next v3] af_unix: Fix undefined 'other' error
Date: Tue, 18 Feb 2025 10:39:22 -0800 [thread overview]
Message-ID: <20250218183922.25318-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20250218141045.38947-1-purvayeshi550@gmail.com>
From: Purva Yeshi <purvayeshi550@gmail.com>
Date: Tue, 18 Feb 2025 19:40:45 +0530
> Fix an issue detected by the Smatch static analysis tool where an
> "undefined 'other'" error occurs due to `__releases(&unix_sk(other)->lock)`
> being placed before 'other' is in scope.
I don't care much, but according to Dan, this is Sparse error due to
const unix_sk() ?
https://lore.kernel.org/all/bbf51850-814a-4a30-8165-625d88f221a5@stanley.mountain/
>
> Remove the `__releases()` annotation from the `unix_wait_for_peer()`
> function to eliminate the Smatch warning. The annotation references `other`
Same here ?
> before it is declared, leading to a false positive error during static
> analysis.
>
> Since AF_UNIX does not use Sparse annotations, this annotation is
> unnecessary and does not impact functionality.
>
> Signed-off-by: Purva Yeshi <purvayeshi550@gmail.com>
Anyway,
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Also, I think you can carry over Joe and Simon's tags as the change is
trivial.
next prev parent reply other threads:[~2025-02-18 18:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 14:10 [PATCH net-next v3] af_unix: Fix undefined 'other' error Purva Yeshi
2025-02-18 18:39 ` Kuniyuki Iwashima [this message]
2025-02-21 1:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250218183922.25318-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=purvayeshi550@gmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox